Revert changes to Future.chain() and Future.transform() from http://codereview.chromium.org/10517006

Revert changes to Future.chain() and Future.transform() from http://codereview.chromium.org/10517006

Since onComplete swallows exceptions, the new implementation doesn't propagate exceptions thrown by the transforming function, where there's a then() handler but no handleException() handler.

The right fix is to invoke handlers (including the default 'throw the exception' error handler) on the event loop rather than synchronously, but there's no API for that in corelib yet.

BUG=3489
Committed: https://code.google.com/p/dart/source/detail?r=8501

[sammccall, 2012-06-10 22:18:09]

http://codereview.chromium.org/10537096/diff/1/tests/corelib/future_test.dart
File tests/corelib/future_test.dart (right):

http://codereview.chromium.org/10537096/diff/1/tests/corelib/future_test.dart...
tests/corelib/future_test.dart:393: Expect.throws(() =>
completer.complete("42"), check: (e) => e == error);
This covers bug 3489

[Siggi Cherem (dart-lang), 2012-06-11 16:02:15]

lgtm

[Siggi Cherem (dart-lang), 2012-06-11 16:09:45]

submitted in r8501