Disable the radio button of a content settings bubble if the content setting for the current site i…

chrome/browser/ui/views/content_setting_bubble_contents.cc

Index: chrome/browser/ui/views/content_setting_bubble_contents.cc
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.cc b/chrome/browser/ui/views/content_setting_bubble_contents.cc
index 75f07550e151f0ee3f896f40132ddd440ed046f9..1e2e9d5dbc6f445f20926622ff01ef8903f8ba16 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.cc
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.cc
@@ -208,6 +208,8 @@ void ContentSettingBubbleContents::Init() {
          radio_group.radio_items.begin();
          i != radio_group.radio_items.end(); ++i) {
       views::RadioButton* radio = new views::RadioButton(UTF8ToUTF16(*i), 0);
+      if (!bubble_content.radio_group_enabled)

[tfarina, 2012/06/08 21:21:48]

this seems logically correct. would be worth to do this unconditionally though?

outside the loop:
const bool is_enabled = bubble_content.radio_group_enable;

inside the loop:
radio->SetEnabled(is_enabled);

Just a suggestion, up to you of course.

[markusheintz_, 2012/06/11 13:25:04]

Thanks for pointing this out.

I guess I can even do:
  radio->SetEnabled(bubble_content.radio_group_enable);

Then I even save the local variable.

+        radio->SetEnabled(false);
       radio->set_listener(this);
       radio_group_.push_back(radio);
       layout->StartRow(0, single_column_set_id);