Disable the radio button of a content settings bubble if the content setting for the current site i…

chrome/browser/ui/views/content_setting_bubble_contents.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/content_setting_bubble_contents.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 190 matching lines @@
 
   const ContentSettingBubbleModel::RadioGroup& radio_group =
       bubble_content.radio_group;
   if (!radio_group.radio_items.empty()) {
     if (!bubble_content_empty)
       layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
     for (ContentSettingBubbleModel::RadioItems::const_iterator i =
          radio_group.radio_items.begin();
          i != radio_group.radio_items.end(); ++i) {
       views::RadioButton* radio = new views::RadioButton(UTF8ToUTF16(*i), 0);
+      if (!bubble_content.radio_group_enabled)

[tfarina, 2012/06/08 21:21:48]

this seems logically correct. would be worth to do this unconditionally though?

outside the loop:
const bool is_enabled = bubble_content.radio_group_enable;

inside the loop:
radio->SetEnabled(is_enabled);

Just a suggestion, up to you of course.

[markusheintz_, 2012/06/11 13:25:04]

Thanks for pointing this out.

I guess I can even do:
  radio->SetEnabled(bubble_content.radio_group_enable);

Then I even save the local variable.

+        radio->SetEnabled(false);
       radio->set_listener(this);
       radio_group_.push_back(radio);
       layout->StartRow(0, single_column_set_id);
       layout->AddView(radio);
       bubble_content_empty = false;
     }
     DCHECK(!radio_group_.empty());
     // Now that the buttons have been added to the view hierarchy, it's safe
     // to call SetChecked() on them.
     radio_group_[radio_group.default_item]->SetChecked(true);
@@ skipping 102 matching lines @@
 }
 
 void ContentSettingBubbleContents::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK(type == content::NOTIFICATION_WEB_CONTENTS_DESTROYED);
   DCHECK(source == content::Source<WebContents>(web_contents_));
   web_contents_ = NULL;
 }