Issue 10536168: Close a _FileInputStream only immediately before onClosed is called, so .closed returns false befor…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10536168: Close a _FileInputStream only immediately before onClosed is called, so .closed returns false befor… (Closed)

Created:
8 years, 6 months ago by Bill Hesse

Modified:
8 years, 6 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Close a _FileInputStream only immediately before onClosed is called, so .closed returns false before that. BUG=3601 TEST=standalone/io/file_test Committed: https://code.google.com/p/dart/source/detail?r=8649

Patch Set 1 #

Patch Set 2 : Optimize early bailout when reading a closing input stream. #

Total comments: 2

Patch Set 3 : Fix extra line break. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	runtime/bin/stream_util.dart	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
	M	tests/standalone/io/file_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM http://codereview.chromium.org/10536168/diff/2001/runtime/bin/stream_util.dart File runtime/bin/stream_util.dart (right): http://codereview.chromium.org/10536168/diff/2001/runtime/bin/stream_util.dart#newcode125 runtime/bin/stream_util.dart:125: _scheduledCloseCallback == null) { Can this be on ...

8 years, 6 months ago (2012-06-14 11:24:07 UTC) #2

Bill Hesse

8 years, 6 months ago (2012-06-14 11:41:00 UTC) #3

http://codereview.chromium.org/10536168/diff/2001/runtime/bin/stream_util.dart
File runtime/bin/stream_util.dart (right):

http://codereview.chromium.org/10536168/diff/2001/runtime/bin/stream_util.dar...
runtime/bin/stream_util.dart:125: _scheduledCloseCallback == null) {
On 2012/06/14 11:24:07, ajohnsen wrote:
> Can this be on one line?

Yes.

Expand Messages | Collapse Messages