Add stack check in loops so that loops can be stopped. Optimize relational operations.

Add stack check in loops so that loops can be stopped. Optimize relational operations.
Use class-ids to describe type of operation. Should we adapt BinaryOp to use class ids as well?
Committed: https://code.google.com/p/dart/source/detail?r=8507

[Vyacheslav Egorov (Google), 2012-06-11 12:51:21]

lgtm 

> Should we adapt BinaryOp to use class ids as well?

I the following concern about using class ids directly in the future: how are we
going to distinguish specialized operation that accepts boxed arguments from
specialized operation that accepts unboxed arguments (e.g. doubles in xmm
registers or int32 values in registers).

http://codereview.chromium.org/10536086/diff/12006/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_x64.cc (right):

http://codereview.chromium.org/10536086/diff/12006/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_x64.cc:1017: __ movq(TMP,
Immediate(Isolate::Current()->stack_limit_address()));
I though we can use TMP only in the assembler itself.

[srdjan, 2012-06-11 16:00:50]

Added a comment to relational-op that we need to move the 'operator-type' from
class ids to an enum that describes boxed an unboxed variables.

http://codereview.chromium.org/10536086/diff/12006/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_x64.cc (right):

http://codereview.chromium.org/10536086/diff/12006/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_x64.cc:1017: __ movq(TMP,
Immediate(Isolate::Current()->stack_limit_address()));
On 2012/06/11 12:51:21, Vyacheslav Egorov (Google) wrote:
> I though we can use TMP only in the assembler itself.

Yes, unfortunately, we are using TMP outside in several case.  Will fix that in
a following CL. Allocating a temporary here.