Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/browser/android/content_view_impl.h

Issue 10536066: android content shell bringup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more jam feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_impl.h
diff --git a/content/browser/android/content_view_impl.h b/content/browser/android/content_view_impl.h
new file mode 100644
index 0000000000000000000000000000000000000000..d6447ab9c6d6e142c54b403c74b8535044925bec
--- /dev/null
+++ b/content/browser/android/content_view_impl.h
@@ -0,0 +1,49 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
+#define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
+#pragma once
+
+#include <jni.h>
+#include <vector>
+
+#include "base/android/jni_helper.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/android/content_view.h"
jam 2012/06/14 01:31:41 nit: order
+
+class ContentViewClient;
+
+namespace content {
+
+// TODO(jrg): this is a shell. Upstream the rest.
+class ContentViewImpl : public ContentView,
+ public content::NotificationObserver {
jam 2012/06/14 01:31:41 nit: here and below, no need for "content::"
+ public:
+ ContentViewImpl(JNIEnv* env,
+ jobject obj);
+ virtual void Destroy(JNIEnv* env, jobject obj);
+
+ private:
+ // NotificationObserver implementation.
+ virtual void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) OVERRIDE;
+
+ // --------------------------------------------------------------------------
+ // Private methods that call to Java via JNI
+ // --------------------------------------------------------------------------
+ virtual ~ContentViewImpl();
+
+ // --------------------------------------------------------------------------
+ // Other private methods and data
+ // --------------------------------------------------------------------------
+ DISALLOW_COPY_AND_ASSIGN(ContentViewImpl);
+};
+
+bool RegisterContentView(JNIEnv* env);
+
+}; // namespace content
+
+#endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698