Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: content/browser/android/content_view_impl.h

Issue 10536066: android content shell bringup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more jam feedback Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
7 #pragma once
8
9 #include <jni.h>
10 #include <vector>
11
12 #include "base/android/jni_helper.h"
13 #include "content/public/browser/notification_observer.h"
14 #include "content/public/browser/android/content_view.h"
jam 2012/06/14 01:31:41 nit: order
15
16 class ContentViewClient;
17
18 namespace content {
19
20 // TODO(jrg): this is a shell. Upstream the rest.
21 class ContentViewImpl : public ContentView,
22 public content::NotificationObserver {
jam 2012/06/14 01:31:41 nit: here and below, no need for "content::"
23 public:
24 ContentViewImpl(JNIEnv* env,
25 jobject obj);
26 virtual void Destroy(JNIEnv* env, jobject obj);
27
28 private:
29 // NotificationObserver implementation.
30 virtual void Observe(int type,
31 const content::NotificationSource& source,
32 const content::NotificationDetails& details) OVERRIDE;
33
34 // --------------------------------------------------------------------------
35 // Private methods that call to Java via JNI
36 // --------------------------------------------------------------------------
37 virtual ~ContentViewImpl();
38
39 // --------------------------------------------------------------------------
40 // Other private methods and data
41 // --------------------------------------------------------------------------
42 DISALLOW_COPY_AND_ASSIGN(ContentViewImpl);
43 };
44
45 bool RegisterContentView(JNIEnv* env);
46
47 }; // namespace content
48
49 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698