Add buffering to File.openInputStream, so that the entire file is not read in at once.

Add buffering to File.openInputStream, so that the entire file is not read in at once.


BUG=dart:3334
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8395

[Søren Gjesse, 2012-06-07 12:17:12]

lgtm

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:15: });
Indentation.

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:42: // Expect.isTrue(_filePosition < _fileLength);
Code in comments.

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:74: List<int> result = new Uint8List(bytesToRead);
Maybe we can avoid the copying here if reading the exact content of _data - the
_data can be returned.

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:89: _position += len;
Maybe refactor the duplicate (here and above in _read) code for filling the
buffer.

[Bill Hesse, 2012-06-07 13:15:08]

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:15: });
On 2012/06/07 12:17:13, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:42: // Expect.isTrue(_filePosition < _fileLength);
On 2012/06/07 12:17:13, Søren Gjesse wrote:
> Code in comments.

Done.

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:48: var future =  _openedFile.readList(_data, 0,
_data.length);
tab?

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:49: future.transform((read) {
future = future.transform

Fixed.

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:74: List<int> result = new Uint8List(bytesToRead);
On 2012/06/07 12:17:13, Søren Gjesse wrote:
> Maybe we can avoid the copying here if reading the exact content of _data -
the
> _data can be returned.

Done.

http://codereview.chromium.org/10536029/diff/4/runtime/bin/file_impl.dart#new...
runtime/bin/file_impl.dart:89: _position += len;
On 2012/06/07 12:17:13, Søren Gjesse wrote:
> Maybe refactor the duplicate (here and above in _read) code for filling the
> buffer.

Done.

[Mads Ager (google), 2012-06-08 05:55:58]

DBC

http://codereview.chromium.org/10536029/diff/5002/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/10536029/diff/5002/runtime/bin/file_impl.dart#...
runtime/bin/file_impl.dart:1084: bool get closed() => _id == 0;
You are exposing this now. Add it to the interface and document it. :)