Issue 10535157: [WIP] attempt to allow chrome OS to inject its wifi data provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535157: [WIP] attempt to allow chrome OS to inject its wifi data provider (Closed)

Created:
8 years, 6 months ago by joth

Modified:
7 years, 9 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@remove_radio

Visibility:
Public.

More Reviews

Description

[WIP] attempt to allow chrome OS to inject its wifi data provider This still needs the WifiDataProvideImplBase class (and its dependencies) to be moved into the content/public folder. Not clear if that's desired. Remove dependency from chrome onto content non-public API This removes the need for calling private set-provider API BUG= TEST=

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+303 lines, -702 lines)			Patch
M	chrome/browser/DEPS	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/geolocation/wifi_data_provider_chromeos.cc	View	3 chunks	+5 lines, -19 lines	0 comments	Download
D	content/browser/geolocation/device_data_provider.h	View	1 chunk	+0 lines, -306 lines	0 comments	Download
D	content/browser/geolocation/device_data_provider.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	content/browser/geolocation/device_data_provider_unittest.cc	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	content/browser/geolocation/empty_device_data_provider.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	content/browser/geolocation/empty_device_data_provider.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/geolocation/network_location_provider.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/geolocation/network_location_provider_unittest.cc	View	5 chunks	+15 lines, -21 lines	0 comments	Download
M	content/browser/geolocation/network_location_request.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	content/browser/geolocation/wifi_data_provider.h	View	7 chunks	+83 lines, -159 lines	0 comments	Download
A	content/browser/geolocation/wifi_data_provider.cc	View	1 chunk	+139 lines, -0 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_common.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_common_unittest.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
D	content/browser/geolocation/wifi_data_provider_common_win.h	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	content/browser/geolocation/wifi_data_provider_common_win.cc	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_linux.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_mac.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
A +	content/browser/geolocation/wifi_data_provider_unittest.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	content/browser/geolocation/wifi_data_provider_win.cc	View	2 chunks	+41 lines, -1 line	0 comments	Download
M	content/content_browser.gypi	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	content/content_tests.gypi	View	3 chunks	+2 lines, -2 lines	0 comments	Download