TabContentsWrapper -> TabContents, part 12.

TabContentsWrapper -> TabContents, part 12.

Extensions.

BUG=131026
TEST=no change


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141590

[Avi (use Gerrit), 2012-06-11 14:32:07]

ping

[Aaron Boodman, 2012-06-11 22:04:26]

LGTM

Looks pretty mechanical to me. Is there anything you wanted me to look at
closely?

http://codereview.chromium.org/10535077/diff/12002/chrome/browser/extensions/...
File chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
(right):

http://codereview.chromium.org/10535077/diff/12002/chrome/browser/extensions/...
chrome/browser/extensions/api/extension_action/browser_action_apitest.cc:83:
WebContents* tab = browser()->GetActiveWebContents();
Do these have the exact same semantics?

[Avi (use Gerrit), 2012-06-11 22:12:23]

Very mechanical.

Re GetSelectedWebContents > GetActiveWebContents, yes. Ever since we added
multiple tab selection, there was a TODO to do this rename since the latter name
was more precise. Since I was in there anyway renaming similar functions, I
threw this rename in for the fun of it.

[commit-bot: I haz the power, 2012-06-11 22:12:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10535077/12002

[commit-bot: I haz the power, 2012-06-11 22:13:22]

Failed to apply patch for
chrome/browser/extensions/execute_code_in_tab_function.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/execute_code_in_tab_function.cc
Hunk #1 FAILED at 16.
Hunk #2 FAILED at 62.
Hunk #3 FAILED at 220.
3 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/extensions/execute_code_in_tab_function.cc.rej

[commit-bot: I haz the power, 2012-06-11 22:21:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10535077/4004

[commit-bot: I haz the power, 2012-06-11 22:22:05]

Presubmit check for 10535077-4004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/sync
    chrome/browser/sessions

Presubmit checks took 5.3s to calculate.

[Avi (use Gerrit), 2012-06-11 22:26:56]

Moar owners for boring changes.

[sky, 2012-06-11 23:09:59]

LGTM

[Andrew T Wilson (Slow), 2012-06-11 23:23:00]

browser/sync LGTM

[commit-bot: I haz the power, 2012-06-12 00:02:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10535077/4004

[commit-bot: I haz the power, 2012-06-12 01:53:38]

Change committed as 141590