chrome/renderer/resources/extensions/content_settings_custom_bindings.js - Issue 10535030: Allow updateArgumentsPostValidate to support callbacks and added / removed arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/content_settings_custom_bindings.js

Issue 10535030: Allow updateArgumentsPostValidate to support callbacks and added / removed arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Unit tests Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/extension_dispatcher.cc ('K') | « chrome/renderer/renderer_resources.grd ('k') | chrome/renderer/resources/extensions/declarative_webrequest_custom_bindings.js » ('j') | chrome/renderer/resources/extensions/schema_generated_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/content_settings_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/content_settings_custom_bindings.js b/chrome/renderer/resources/extensions/content_settings_custom_bindings.js

index 826ff4553bd0e412da8569be70a03287a0fa5279..9816a0cf499eb61f5c5f38c01ff6cdeede1cdcfa 100644

--- a/chrome/renderer/resources/extensions/content_settings_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/content_settings_custom_bindings.js

@@ -6,6 +6,7 @@

var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

var sendRequest = require('sendRequest').sendRequest;

+var validate = require('validateUtils').validate;

chromeHidden.registerCustomType('contentSettings.ContentSetting', function() {

function extendSchema(schema) {

@@ -17,7 +18,7 @@ chromeHidden.registerCustomType('contentSettings.ContentSetting', function() {

function ContentSetting(contentType, settingSchema) {

this.get = function(details, callback) {

var getSchema = this.parameters.get;

- chromeHidden.validate([details, callback], getSchema);

+ validate([details, callback], getSchema);

return sendRequest('contentSettings.get',

[contentType, details, callback],

extendSchema(getSchema));

@@ -25,21 +26,21 @@ chromeHidden.registerCustomType('contentSettings.ContentSetting', function() {

this.set = function(details, callback) {

var setSchema = this.parameters.set.slice();

setSchema[0].properties.setting = settingSchema;

- chromeHidden.validate([details, callback], setSchema);

+ validate([details, callback], setSchema);

return sendRequest('contentSettings.set',

[contentType, details, callback],

extendSchema(setSchema));

};

this.clear = function(details, callback) {

var clearSchema = this.parameters.clear;

- chromeHidden.validate([details, callback], clearSchema);

+ validate([details, callback], clearSchema);

return sendRequest('contentSettings.clear',

[contentType, details, callback],

extendSchema(clearSchema));

};

this.getResourceIdentifiers = function(callback) {

var schema = this.parameters.getResourceIdentifiers;

- chromeHidden.validate([callback], schema);

+ validate([callback], schema);

return sendRequest(

'contentSettings.getResourceIdentifiers',

[contentType, callback],