chrome/renderer/extensions/extension_dispatcher.cc - Issue 10535030: Allow updateArgumentsPostValidate to support callbacks and added / removed arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_dispatcher.cc

Issue 10535030: Allow updateArgumentsPostValidate to support callbacks and added / removed arguments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Unit tests Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/event_unittest.cc ('k') | chrome/renderer/renderer_resources.grd » ('j') | chrome/renderer/resources/extensions/schema_generated_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/extension_dispatcher.cc

diff --git a/chrome/renderer/extensions/extension_dispatcher.cc b/chrome/renderer/extensions/extension_dispatcher.cc

index d1ed29ab48b4d1ab159110f332a406a6b2d918f8..0db6c829f78a9e62955cc646207a47270aca6405 100644

--- a/chrome/renderer/extensions/extension_dispatcher.cc

+++ b/chrome/renderer/extensions/extension_dispatcher.cc

@@ -543,6 +543,7 @@ void ExtensionDispatcher::PopulateSourceMap() {

source_map_.RegisterSource("sendRequest", IDR_SEND_REQUEST_JS);

source_map_.RegisterSource("setIcon", IDR_SET_ICON_JS);

source_map_.RegisterSource("utils", IDR_UTILS_JS);

+ source_map_.RegisterSource("validateUtils", IDR_VALIDATE_UTILS_JS);

not at google - send to devlin 2012/06/07 00:17:11 Bikeshed moment: I'd have called it schemaUtil co

benwells 2012/06/07 01:45:40 Done (as schemaUtils).

// Custom bindings.

source_map_.RegisterSource("app", IDR_APP_CUSTOM_BINDINGS_JS);