Issue 10534152: Add RecommendSampleRate to audio config test.

Issue 10534152: Add RecommendSampleRate to audio config test. (Closed)

Created:
8 years, 6 months ago by nfullagar

Modified:
8 years, 6 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add RecommendSampleRate() to audio config test. BUG=none TEST=this is the test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142867

Patch Set 6 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
M	chrome/test/ui/ppapi_uitest.cc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/tests/test_audio_config.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/tests/test_audio_config.cc	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

http://codereview.chromium.org/10534152/diff/3002/ppapi/tests/test_audio_config.cc File ppapi/tests/test_audio_config.cc (right): http://codereview.chromium.org/10534152/diff/3002/ppapi/tests/test_audio_config.cc#newcode40 ppapi/tests/test_audio_config.cc:40: // Ask PPB_AudioConfig about the recommended sample rate. Please ...

8 years, 6 months ago (2012-06-15 21:33:17 UTC) #2

nfullagar

On 2012/06/15 21:33:17, viettrungluu wrote: > http://codereview.chromium.org/10534152/diff/3002/ppapi/tests/test_audio_config.cc > File ppapi/tests/test_audio_config.cc (right): > > http://codereview.chromium.org/10534152/diff/3002/ppapi/tests/test_audio_config.cc#newcode40 > ...

8 years, 6 months ago (2012-06-15 23:23:17 UTC) #3

viettrungluu

LGTM on the test, but could you also add the new test to ppapi_uitest.cc?

8 years, 6 months ago (2012-06-18 16:25:15 UTC) #4

nfullagar

On 2012/06/18 16:25:15, viettrungluu wrote: > LGTM on the test, but could you also add ...

8 years, 6 months ago (2012-06-18 20:44:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10534152/22001

8 years, 6 months ago (2012-06-18 20:44:57 UTC) #6

commit-bot: I haz the power

Try job failure for 10534152-22001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...

8 years, 6 months ago (2012-06-18 22:03:51 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10534152/22001

8 years, 6 months ago (2012-06-18 22:45:58 UTC) #8

Change committed as 142867

Expand Messages | Collapse Messages