Issue 10534147: Allow platform apps to open links in the browser.

Issue 10534147: Allow platform apps to open links in the browser. (Closed)

Created:
8 years, 6 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 6 months ago

Reviewers:
miket_OOO, jam

CC:
chromium-reviews, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow platform apps to open links in the browser. Triggered via <a href="..." target="_blank"> or window.open('...'). R=miket@chromium.org BUG=130213 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142292

Patch Set 3 : Fix clang warning #

Patch Set 4 : Move ConsoleMessageLevel to common_param_traits #

Total comments: 2

Patch Set 5 : Fix shared library build #

Total comments: 4

Patch Set 6 : Review feedback #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -70 lines)			Patch
M	chrome/browser/extensions/platform_app_browsertest.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/extensions/shell_window.h	View	1 2 3 4	3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/extensions/shell_window.cc	View	1 2 3 4 5	4 chunks	+72 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_messages.h	View	1 2 3 4 5	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_helper.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/extension_helper.cc	View		6 chunks	+34 lines, -6 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/open_link/link.html	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/open_link/main.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/platform_apps/open_link/main.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/open_link/manifest.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/open_link/test.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/common/devtools_messages.h	View	1 2 3	2 chunks	+1 line, -18 lines	0 comments	Download
D	content/common/devtools_messages.cc	View	1 2 3	1 chunk	+0 lines, -44 lines	0 comments	Download
M	content/content_common.gypi	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/common_param_traits.h	View	1 2 3 4	2 chunks	+9 lines, -0 lines	0 comments	Download
M	content/public/common/common_param_traits.cc	View	1 2 3	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

I needed to move some IPC traits around, since ConsoleMessageLevel had traits in both extension_messages.h ...

8 years, 6 months ago (2012-06-14 01:12:36 UTC) #2

jam

content lgtm http://codereview.chromium.org/10534147/diff/26/chrome/common/extensions/extension_messages.h File chrome/common/extensions/extension_messages.h (right): http://codereview.chromium.org/10534147/diff/26/chrome/common/extensions/extension_messages.h#newcode17 chrome/common/extensions/extension_messages.h:17: #include "content/public/common/console_message_level.h" nit: redundant, since you're including ...

8 years, 6 months ago (2012-06-14 03:59:55 UTC) #3

miket_OOO

LGTM. I only skimmed content/. http://codereview.chromium.org/10534147/diff/3005/chrome/browser/ui/extensions/shell_window.cc File chrome/browser/ui/extensions/shell_window.cc (right): http://codereview.chromium.org/10534147/diff/3005/chrome/browser/ui/extensions/shell_window.cc#newcode144 chrome/browser/ui/extensions/shell_window.cc:144: "Can't navigate to \"%s\", ...

8 years, 6 months ago (2012-06-14 23:06:44 UTC) #4

Mihai Parparita -not on Chrome

http://codereview.chromium.org/10534147/diff/26/chrome/common/extensions/extension_messages.h File chrome/common/extensions/extension_messages.h (right): http://codereview.chromium.org/10534147/diff/26/chrome/common/extensions/extension_messages.h#newcode17 chrome/common/extensions/extension_messages.h:17: #include "content/public/common/console_message_level.h" On 2012/06/14 03:59:55, John Abd-El-Malek wrote: > ...

8 years, 6 months ago (2012-06-14 23:10:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10534147/8009

8 years, 6 months ago (2012-06-14 23:13:33 UTC) #6

Change committed as 142292

Expand Messages | Collapse Messages