Generalize AesDecryptor to make it more spec compliant.

media/filters/chunk_demuxer_client.h

Index: media/filters/chunk_demuxer_client.h
diff --git a/media/filters/chunk_demuxer_client.h b/media/filters/chunk_demuxer_client.h
index 3fbe6e351d00e5705cd26e0a44595400e95cf57f..258d8a59f2c6b68612590f5cbd985ea7a5e6c4b8 100644
--- a/media/filters/chunk_demuxer_client.h
+++ b/media/filters/chunk_demuxer_client.h
@@ -25,7 +25,11 @@ class ChunkDemuxerClient {
   // A decryption key associated with |init_data| may be needed to decrypt the
   // media being demuxed before decoding. Note that the demuxing itself does not
   // need decryption.
-  virtual void KeyNeeded(scoped_array<uint8> init_data, int init_data_size) = 0;
+  virtual void DemuxerNeedKey(scoped_array<uint8> init_data,
+                              int init_data_size) = 0;
+
+ protected:
+  ~ChunkDemuxerClient() {}

[scherkus (not reviewing), 2012/06/13 23:35:08]

virtual

[xhwang, 2012/06/15 01:41:04]

Done. Also done for DecryptorClient::~DecryptorClient.

[ddorwin, 2012/06/15 04:29:25]

Why does this need to be virtual? Delete is never called on this pointer type
(the destructor is protected).

[scherkus (not reviewing), 2012/06/15 04:36:36]

Refer to both Google C++ style guide (all methods are virtual, including dtor)
and recent thread on chromium-dev that discussed this exact situation:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/n5IAT9wywPo/dis...

It was decided to not further diverge from Google C++ style

[xhwang, 2012/06/15 16:39:18]

Yeah, I discussed this with scherkus and forwarded it to ddorwin off-line.

 };
 
 }  // namespace media