Generalize AesDecryptor to make it more spec compliant.

media/filters/chunk_demuxer_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_CHUNK_DEMUXER_CLIENT_H_
 #define MEDIA_FILTERS_CHUNK_DEMUXER_CLIENT_H_
 
 #include "base/memory/scoped_ptr.h"
 
 namespace media {
 
 class ChunkDemuxer;
 
 // Interface used to notify an external object when a ChunkDemuxer
 // is opened & closed.
 class ChunkDemuxerClient {
  public:
   // Called when a ChunkDemuxer object is opened.
   virtual void DemuxerOpened(ChunkDemuxer* demuxer) = 0;
 
   // The ChunkDemuxer passed via last DemuxerOpened() call is now
   // closed. Any further calls on the demuxer will result in an error.
   virtual void DemuxerClosed() = 0;
 
   // A decryption key associated with |init_data| may be needed to decrypt the
   // media being demuxed before decoding. Note that the demuxing itself does not
   // need decryption.
-  virtual void KeyNeeded(scoped_array<uint8> init_data, int init_data_size) = 0;
+  virtual void DemuxerNeedKey(scoped_array<uint8> init_data,
+                              int init_data_size) = 0;
+
+ protected:
+  ~ChunkDemuxerClient() {}

[scherkus (not reviewing), 2012/06/13 23:35:08]

virtual

[xhwang, 2012/06/15 01:41:04]

Done. Also done for DecryptorClient::~DecryptorClient.

[ddorwin, 2012/06/15 04:29:25]

Why does this need to be virtual? Delete is never called on this pointer type
(the destructor is protected).

[scherkus (not reviewing), 2012/06/15 04:36:36]

Refer to both Google C++ style guide (all methods are virtual, including dtor)
and recent thread on chromium-dev that discussed this exact situation:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/n5IAT9wywPo/dis...

It was decided to not further diverge from Google C++ style

[xhwang, 2012/06/15 16:39:18]

Yeah, I discussed this with scherkus and forwarded it to ddorwin off-line.

 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_CHUNK_DEMUXER_CLIENT_H_