chrome/browser/extensions/settings/settings_quota_unittest.cc - Issue 10533116: Unrevert 141514: Remove CachingValueStore in favor of an async ValueStoreFrontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings/settings_quota_unittest.cc

Issue 10533116: Unrevert 141514: Remove CachingValueStore in favor of an async ValueStoreFrontend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/settings/settings_backend.cc ('k') | chrome/browser/extensions/settings/settings_sync_unittest.cc » ('j') | chrome/browser/value_store/value_store_frontend.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/settings/settings_quota_unittest.cc

diff --git a/chrome/browser/extensions/settings/settings_quota_unittest.cc b/chrome/browser/extensions/settings/settings_quota_unittest.cc

index 947e248d335ec74b44dd79a66097c981be66b542..c8b66c62c69a5fdfa72874ff8d1eaf2c4f77cd5b 100644

--- a/chrome/browser/extensions/settings/settings_quota_unittest.cc

+++ b/chrome/browser/extensions/settings/settings_quota_unittest.cc

@@ -25,7 +25,7 @@ class ExtensionSettingsQuotaTest : public testing::Test {

: byte_value_1_(Value::CreateIntegerValue(1)),

byte_value_16_(Value::CreateStringValue("sixteen bytes.")),

byte_value_256_(new ListValue()),

- delegate_(new TestingSettingsStorage()) {

+ delegate_(new TestingValueStore()) {

for (int i = 1; i < 89; ++i) {

byte_value_256_->Append(Value::CreateIntegerValue(i));

}

@@ -72,7 +72,7 @@ class ExtensionSettingsQuotaTest : public testing::Test {

scoped_ptr<SettingsStorageQuotaEnforcer> storage_;

// In-memory storage area being delegated to. Always owned by |storage_|.

- TestingSettingsStorage* delegate_;

+ TestingValueStore* delegate_;

};

TEST_F(ExtensionSettingsQuotaTest, ZeroQuotaBytes) {