chrome/browser/extensions/settings/settings_backend.cc - Issue 10533116: Unrevert 141514: Remove CachingValueStore in favor of an async ValueStoreFrontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/settings/settings_backend.cc

Issue 10533116: Unrevert 141514: Remove CachingValueStore in favor of an async ValueStoreFrontend. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/settings/settings_backend.cc

diff --git a/chrome/browser/extensions/settings/settings_backend.cc b/chrome/browser/extensions/settings/settings_backend.cc

index 5ce41539df096761485b2276d77b86ec2319040a..c43dfdabb60a6ad08b08e4da0916cbc0634f0184 100644

--- a/chrome/browser/extensions/settings/settings_backend.cc

+++ b/chrome/browser/extensions/settings/settings_backend.cc

@@ -63,7 +63,7 @@ SyncableSettingsStorage* SettingsBackend::GetOrCreateStorageWithSyncData(

// sync will only go ahead if each underlying storage operation succeeds.

storage = new SettingsStorageQuotaEnforcer(quota_, storage);

} else {

- storage = new FailingSettingsStorage();

+ storage = new FailingValueStore();

}

linked_ptr<SyncableSettingsStorage> syncable_storage(

« no previous file with comments | « no previous file | chrome/browser/extensions/settings/settings_quota_unittest.cc » ('j') | chrome/browser/value_store/value_store_frontend.cc » ('J')