Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: tests/standalone/io/http_server_socket_test.dart

Issue 10533078: Enable standalone/io/http_test, splitting it into three separate tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/http_server_socket_test.dart
diff --git a/tests/standalone/io/http_server_socket_test.dart b/tests/standalone/io/http_server_socket_test.dart
index be09c2ba1845d04d344267eef8f96a999558ac2c..cbeaf8a32b6e03091351e89597d767e651b322ec 100644
--- a/tests/standalone/io/http_server_socket_test.dart
+++ b/tests/standalone/io/http_server_socket_test.dart
@@ -169,8 +169,8 @@ void testSocketClose() {
HttpServer server = new HttpServer();
server.listenOn(serverSocket);
- void testContent(String request,
- String response,
+ void testContent(String requestString,
+ String responseString,
[int okayFrom = 0,
bool expectError = true]) {
// Inner callback to actually run a given setting.
@@ -197,11 +197,12 @@ void testSocketClose() {
};
}
- serverSocket.spawnSocket(request, response, cutoff, closeAsError);
+ serverSocket.spawnSocket(requestString, responseString,
+ cutoff, closeAsError);
// TODO(ajohnsen): Validate HttpServers number of connections.
}
- for (int i = 1; i < response.length; i++) {
- bool _expectError = expectError && i < response.length - okayFrom;
+ for (int i = 1; i < responseString.length; i++) {
+ bool _expectError = expectError && i < responseString.length - okayFrom;
runSettings(i, false, _expectError);
runSettings(i, true, _expectError);
}

Powered by Google App Engine
This is Rietveld 408576698