Issue 10533078: Enable standalone/io/http_test, splitting it into three separate tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10533078: Enable standalone/io/http_test, splitting it into three separate tests. (Closed)

Created:
8 years, 6 months ago by Bill Hesse

Modified:
8 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable standalone/io/http_test, splitting it into three separate tests. This allows better reporting and diagnosis of flakiness. Also fixed some type and interface issues that created type warnings in http tests. BUG=2987 TEST=standalone/io/http_test, http_advanced_test, http_read_test, http_basic_test Committed: https://code.google.com/p/dart/source/detail?r=8491

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+602 lines, -972 lines)			Patch
M	runtime/bin/http.dart	View	1	3 chunks	+13 lines, -2 lines	0 comments	Download
A +	tests/standalone/io/http_advanced_test.dart	View		8 chunks	+3 lines, -277 lines	0 comments	Download
A	tests/standalone/io/http_basic_test.dart	View		1 chunk	+310 lines, -0 lines	0 comments	Download
A	tests/standalone/io/http_read_test.dart	View		1 chunk	+266 lines, -0 lines	0 comments	Download
M	tests/standalone/io/http_server_early_client_close_test.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/standalone/io/http_server_socket_test.dart	View		2 chunks	+6 lines, -5 lines	0 comments	Download
D	tests/standalone/io/http_test.dart	View		1 chunk	+0 lines, -682 lines	0 comments	Download
M	tests/standalone/standalone.status	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years, 6 months ago (2012-06-11 13:19:06 UTC) #2

lgtm

http://codereview.chromium.org/10533078/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

http://codereview.chromium.org/10533078/diff/1/runtime/bin/http.dart#newcode778
runtime/bin/http.dart:778: * Sets the requested persistent connection state.
Sets -> Gets and sets

We should not mention HTTP 1.0 here as the HttpClient cannot be set to use HTTP
1.0. How about just "The default value is [:true:]"

http://codereview.chromium.org/10533078/diff/1/runtime/bin/http.dart#newcode818
runtime/bin/http.dart:818: * Gets the persistent connection state returned by
the server.
I think we should make this a getter. I know the implementation has both getter
and setter, but we could change that as well.

Expand Messages | Collapse Messages