Retry: Make Isolated file system writable only if it is configured so

Retry: Make Isolated file system writable only if it is configured so

- CreateFileStreamWriter wiring in FSO
- Add yet another write-protection at IsolatedContext (in addition to ChildProcessSecurityPolicy, so that we can make each fs read-only or writable in DRT/testing)

BUG=none
TEST=existing tests should pass

Original review URL: https://chromiumcodereview.appspot.com/10540070

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141650

[kinuko, 2012-06-12 06:25:51]

Added CrOSMountPointProvider::CreateFileStreamWriter for local mount points as
the original patch broke chromeos build. Inaba-san could you take one more look?

http://codereview.chromium.org/10532085/diff/9003/webkit/chromeos/fileapi/cro...

[zel, 2012-06-12 06:38:07]

LGTM for ChromeOS part

[kinaba, 2012-06-12 06:39:32]

LGTM with a nit.

http://codereview.chromium.org/10532085/diff/9003/webkit/chromeos/fileapi/cro...
File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right):

http://codereview.chromium.org/10532085/diff/9003/webkit/chromeos/fileapi/cro...
webkit/chromeos/fileapi/cros_mount_point_provider.cc:275: const MountPoint*
mount_point = GetMountPoint(virtual_path);
We need to exit earlier for NULL return:
if (!mount_point)
  return NULL;
otherwise it may bite us in line 280.

[kinuko, 2012-06-12 08:48:12]

On 2012/06/12 06:39:32, kinaba wrote:
> LGTM with a nit.
> 
>
http://codereview.chromium.org/10532085/diff/9003/webkit/chromeos/fileapi/cro...
> File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right):
> 
>
http://codereview.chromium.org/10532085/diff/9003/webkit/chromeos/fileapi/cro...
> webkit/chromeos/fileapi/cros_mount_point_provider.cc:275: const MountPoint*
> mount_point = GetMountPoint(virtual_path);
> We need to exit earlier for NULL return:
> if (!mount_point)
>   return NULL;
> otherwise it may bite us in line 280.

Thanks, will do before submitting!