Retry: Make Isolated file system writable only if it is configured so

webkit/chromeos/fileapi/cros_mount_point_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/chromeos/fileapi/cros_mount_point_provider.h"
 
 #include "base/chromeos/chromeos_version.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/stringprintf.h"
 #include "base/synchronization/lock.h"
 #include "base/utf_string_conversions.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebSecurityOrigin.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebCString.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebFileSystem.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
 #include "webkit/chromeos/fileapi/file_access_permissions.h"
 #include "webkit/chromeos/fileapi/remote_file_system_operation.h"
 #include "webkit/fileapi/file_system_file_stream_reader.h"
 #include "webkit/fileapi/file_system_operation.h"
 #include "webkit/fileapi/file_system_util.h"
+#include "webkit/fileapi/local_file_stream_writer.h"
 #include "webkit/glue/webkit_glue.h"
 
 namespace {
 
 const char kChromeUIScheme[] = "chrome";
 
 // Returns the home directory path, or an empty string if the home directory
 // is not found.
 std::string GetHomeDirectory() {
   if (base::chromeos::IsRunningOnChromeOS())
@@ skipping 228 matching lines @@
   // For now we return a generic Reader implementation which utilizes
   // CreateSnapshotFile internally (i.e. will download everything first).
   // TODO(satorux,zel): implement more efficient reader for remote cases.
   return new fileapi::FileSystemFileStreamReader(context, url, offset);
 }
 
 fileapi::FileStreamWriter* CrosMountPointProvider::CreateFileStreamWriter(
     const GURL& url,
     int64 offset,
     fileapi::FileSystemContext* context) const {
-  // TODO(kinaba,kinuko,benchan,satorux): return a writer for remote or local
-  // file system depending on the mount point location.
-  NOTIMPLEMENTED();
-  return NULL;
+  FilePath virtual_path;
+  if (!fileapi::CrackFileSystemURL(url, NULL, NULL, &virtual_path))
+    return NULL;
+  const MountPoint* mount_point = GetMountPoint(virtual_path);

[kinaba, 2012/06/12 06:39:32]

We need to exit earlier for NULL return:
if (!mount_point)
  return NULL;
otherwise it may bite us in line 280.

+  if (mount_point && mount_point->location == REMOTE) {
+    // TODO(kinaba): return a gdata writer for remote file system.
+    return NULL;
+  }
+  FilePath root_path = mount_point->local_root_path;
+  return new fileapi::LocalFileStreamWriter(
+      root_path.Append(virtual_path), offset);
 }
 
 bool CrosMountPointProvider::GetVirtualPath(const FilePath& filesystem_path,
                                            FilePath* virtual_path) {
   for (MountPointMap::const_iterator iter = mount_point_map_.begin();
        iter != mount_point_map_.end();
        ++iter) {
     FilePath mount_prefix = iter->second.local_root_path.Append(iter->first);
     *virtual_path = FilePath(iter->first);
     if (mount_prefix == filesystem_path) {
       return true;
     } else if (mount_prefix.AppendRelativePath(filesystem_path, virtual_path)) {
       return true;
     }
   }
   return false;
 }
 
 }  // namespace chromeos