Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 10532054: Fix for issue 1343 (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson
Modified:
8 years, 6 months ago
Reviewers:
zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 4 chunks +31 lines, -4 lines 2 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 1 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Brian Wilkerson
8 years, 6 months ago (2012-06-07 18:46:15 UTC) #1
zundel
Hi Brian, I usually write a JUnit test as well to make sure the right ...
8 years, 6 months ago (2012-06-07 18:51:43 UTC) #2
Brian Wilkerson
> I usually write a JUnit test as well to make sure the right error ...
8 years, 6 months ago (2012-06-07 20:54:02 UTC) #3
zundel
lgtm http://codereview.chromium.org/10532054/diff/6001/compiler/java/com/google/dart/compiler/resolver/Resolver.java File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right): http://codereview.chromium.org/10532054/diff/6001/compiler/java/com/google/dart/compiler/resolver/Resolver.java#newcode1839 compiler/java/com/google/dart/compiler/resolver/Resolver.java:1839: DartNode anscestor = node; typo: anscestor -> ancestor
8 years, 6 months ago (2012-06-07 21:11:19 UTC) #4
Brian Wilkerson
8 years, 6 months ago (2012-06-07 21:19:05 UTC) #5
http://codereview.chromium.org/10532054/diff/6001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/resolver/Resolver.java (right):

http://codereview.chromium.org/10532054/diff/6001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/resolver/Resolver.java:1839: DartNode
anscestor = node;
Done

Powered by Google App Engine
This is Rietveld 408576698