Fix super call invocation (issue 2028).

Fix super call invocation (issue 2028).
Committed: https://code.google.com/p/dart/source/detail?r=8633

[regis, 2012-06-04 18:16:40]

This is not fixing all the issues with super, but it is a start.
This will have to change again when we support mirrors.

Thanks,
Regis

[hausner, 2012-06-04 18:22:26]

lgtm. Thank you for doing this!

[srdjan, 2012-06-04 23:31:07]

LGTM

http://codereview.chromium.org/10513008/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10513008/diff/1/runtime/vm/parser.cc#newcode1231
runtime/vm/parser.cc:1231: super_func = ResolveDynamicFunction(super_class,
no_such_method_name);
Is it specified whose noSuchMethod should be invoked: the one of the class or of
its super class? Please add a test for that.

http://codereview.chromium.org/10513008/diff/1/runtime/vm/parser.cc#newcode1265
runtime/vm/parser.cc:1265: ArgumentListNode* function_args) {
const ArgumentListNode&

[regis, 2012-06-13 22:15:49]

Thanks!

http://codereview.chromium.org/10513008/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10513008/diff/1/runtime/vm/parser.cc#newcode1231
runtime/vm/parser.cc:1231: super_func = ResolveDynamicFunction(super_class,
no_such_method_name);
On 2012/06/04 23:31:07, srdjan wrote:
> Is it specified whose noSuchMethod should be invoked: the one of the class or
of
> its super class? Please add a test for that.

It must be resolved in the super class, which we do correctly. I added a
language test super_call4_test.dart.

http://codereview.chromium.org/10513008/diff/1/runtime/vm/parser.cc#newcode1265
runtime/vm/parser.cc:1265: ArgumentListNode* function_args) {
On 2012/06/04 23:31:07, srdjan wrote:
> const ArgumentListNode&

Done.