Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2851)

Unified Diff: chrome/browser/web_resource/promo_resource_service.h

Issue 10496008: Purge legacy notification promo code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/promo_resource_service.h
===================================================================
--- chrome/browser/web_resource/promo_resource_service.h (revision 140104)
+++ chrome/browser/web_resource/promo_resource_service.h (working copy)
@@ -28,9 +28,7 @@
// TODO(mirandac): Arrange for a server to be set up specifically for promo
Dan Beam 2012/06/04 18:20:08 this is TODONE()
achuithb 2012/06/04 19:52:59 Done.
// messages, which have until now been piggybacked onto the old tips server
// structure. (see http://crbug.com/70634 for details.)
-class PromoResourceService
- : public WebResourceService,
- public NotificationPromo::Delegate {
+class PromoResourceService : public WebResourceService {
public:
// Identifies types of Chrome builds for promo targeting.
enum BuildType {
@@ -216,10 +214,6 @@
// answer_id: the promo's id
void UnpackWebStoreSignal(const base::DictionaryValue& parsed_json);
- // NotificationPromo::Delegate override.
- virtual void OnNotificationParsed(double start, double end,
- bool new_notification) OVERRIDE;
-
// The profile this service belongs to.
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698