Purge legacy notification promo code.

chrome/browser/web_resource/promo_resource_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_
 #define CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_
 #pragma once
 
 #include <string>
 
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/web_resource/notification_promo.h"
 #include "chrome/browser/web_resource/web_resource_service.h"
 #include "chrome/common/chrome_version_info.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 class AppsPromoLogoFetcher;
 class PrefService;
 class Profile;
 // A PromoResourceService fetches data from a web resource server to be used to
 // dynamically change the appearance of the New Tab Page. For example, it has
 // been used to fetch "tips" to be displayed on the NTP, or to display
 // promotional messages to certain groups of Chrome users.
 //
 // TODO(mirandac): Arrange for a server to be set up specifically for promo

[Dan Beam, 2012/06/04 18:20:08]

this is TODONE()

[achuithb, 2012/06/04 19:52:59]

Done.

 // messages, which have until now been piggybacked onto the old tips server
 // structure. (see http://crbug.com/70634 for details.)
-class PromoResourceService
-    : public WebResourceService,
-      public NotificationPromo::Delegate {
+class PromoResourceService : public WebResourceService {
  public:
   // Identifies types of Chrome builds for promo targeting.
   enum BuildType {
     NO_BUILD = 0,
     DEV_BUILD = 1,
     BETA_BUILD = 1 << 1,
     STABLE_BUILD = 1 << 2,
     CANARY_BUILD = 1 << 3,
     ALL_BUILDS = (1 << 4) - 1,
   };
@@ skipping 65 matching lines @@
 
   // Unpack the web resource as a custom notification signal. Expects a start
   // and end signal, with the promo to be shown in the tooltip of the start
   // signal field. Delivery will be in json in the form of:
   // {
   //   "topic": {
   //     "answers": [
   //       {
   //         "answer_id": "1067976",
   //         "name": "promo_start",
   //         "question": "1:24:10:20:7:0",

[Dan Beam, 2012/06/04 18:41:04]

none of this is the case any more, right?

[achuithb, 2012/06/04 19:52:59]

Done.

   //         "tooltip":
   //       "Click \u003ca href=http://www.google.com\u003ehere\u003c/a\u003e!",
   //         "inproduct": "10/8/09 12:00",
   //         "inproduct_target": null
   //       },
   //       {
   //         "answer_id": "1067976",
   //         "name": "promo_end",
   //         "question": "",
   //         "tooltip": "",
   //         "inproduct": "10/8/11 12:00",
   //         "inproduct_target": null
   //       },
   //       ...
   //     ]
   //   }
   // }
   //
   // Because the promo signal data is piggybacked onto the tip server, the
   // values don't exactly correspond with the field names:
   //
   // For "promo_start" or "promo_end", the date to start or stop showing the
   // promotional line is given by the "inproduct" line.
   // For "promo_start", the promotional line itself is given in the "tooltip"
   // field. The "question" field gives the type of builds that should be shown
   // this promo (see the BuildType enum in web_resource_service.cc), the
   // number of hours that each promo group should see it, the maximum promo
   // group that should see it, the maximum number of views of the promo,the

[Dan Beam, 2012/06/04 18:41:04]

and for the love of all things holy, if we're keeping this text add a space
after the comma here:

  promo,the

it's always annoyed the hell out of me.

[achuithb, 2012/06/04 19:52:59]

Comments are no longer valid (thanks). I've deleted them. This is probably not
the best place to describe the json format.

   // platforms that this promo is suitable for, and a mask of features which
   // must be present in order for the promo to be shown (0 => no feaures needed
   // 1 => user must be logged in to gplus), separated by ":".
   // For example, "7:24:5:10:7:0" would indicate that all groups with ids less
   // than 5, and with dev, beta and stable builds on Windows, Mac and Linux,
   // should see the promo a maximum of 10 times, the promo is suitable for Mac
   // Linux and Windows platforms, and no features are required to show it. The
   // groups ramp up so one additional group sees the promo every 24 hours.
   //
   void UnpackNotificationSignal(const base::DictionaryValue& parsed_json);
@@ skipping 51 matching lines @@
   //   name: starts with "webstore_promo" to identify the signal. The second
   //         part contains the release channels targeted (bitwise or of
   //         BuildTypes). The third part specifies what users should maximize
   //         the apps section of the NTP when first loading the promo (bitwise
   //         or of AppsPromo::UserGroup). The forth part is optional and
   //         specifies the URL of the logo image. If left out, the default
   //         webstore logo will be used. The logo can be an HTTPS or DATA URL.
   //   answer_id: the promo's id
   void UnpackWebStoreSignal(const base::DictionaryValue& parsed_json);
 
-  // NotificationPromo::Delegate override.
-  virtual void OnNotificationParsed(double start, double end,
-                                    bool new_notification) OVERRIDE;
-
   // The profile this service belongs to.
   Profile* profile_;
 
   // Overrides the current Chrome release channel for testing purposes.
   chrome::VersionInfo::Channel channel_;
 
   // Allows the creation of tasks to send a notification.
   // This allows the PromoResourceService to notify the New Tab Page immediately
   // when a new web resource should be shown or removed.
   base::WeakPtrFactory<PromoResourceService> weak_ptr_factory_;
 
   // Notification type when an update is done.
   int notification_type_;
 
   // True if a task has been set to update the cache when a new web resource
   // becomes available.
   bool web_resource_update_scheduled_;
 
   // A helper that downloads the promo logo.
   scoped_ptr<AppsPromoLogoFetcher> apps_promo_logo_fetcher_;
 
   DISALLOW_COPY_AND_ASSIGN(PromoResourceService);
 };
 
 #endif  // CHROME_BROWSER_WEB_RESOURCE_PROMO_RESOURCE_SERVICE_H_