This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/autofill/autofill_manager.cc

Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 146c42923b90c724f4d569dc38f407cb45adf0ce..13f60312dd5d9dab5ad628830004558dd54971f7 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -717,13 +717,14 @@ void AutofillManager::OnHideAutofillPopup() {
     external_delegate_->HideAutofillPopup();
 }
 
-void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds) {
+void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds,
+                                                    int max_length) {
 #if defined(OS_ANDROID)
   NOTIMPLEMENTED();
 #else
   Browser* browser = browser::FindLastActiveWithProfile(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
-  browser->window()->ShowPasswordGenerationBubble(bounds);
+  browser->window()->ShowPasswordGenerationBubble(bounds, max_length);

[Garrett Casto, 2012/05/30 00:46:35]

Note that if we end up having the password generator be passed into the bubble,
I would change this to call some function on Browser
(Browser::CreatePasswordGenerationBubble?) that would create a PasswordGenerator
and then call BrowserWindow::ShowPasswordGenerationBubble using that generator.
This would make the PasswordGenerator code platform agnostic.

[zysxqn, 2012/05/31 21:54:08]

Why can't we create a PasswordGenerator directly here?

 #endif  // #if defined(OS_ANDROID)
 }