This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/autofill/autofill_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 699 matching lines @@
           AutofillMetrics::SUGGESTIONS_SHOWN_ONCE);
     }
   }
 }
 
 void AutofillManager::OnHideAutofillPopup() {
   if (external_delegate_)
     external_delegate_->HideAutofillPopup();
 }
 
-void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds) {
+void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds,
+                                                    int max_length) {
 #if defined(OS_ANDROID)
   NOTIMPLEMENTED();
 #else
   Browser* browser = browser::FindLastActiveWithProfile(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
-  browser->window()->ShowPasswordGenerationBubble(bounds);
+  browser->window()->ShowPasswordGenerationBubble(bounds, max_length);

[Garrett Casto, 2012/05/30 00:46:35]

Note that if we end up having the password generator be passed into the bubble,
I would change this to call some function on Browser
(Browser::CreatePasswordGenerationBubble?) that would create a PasswordGenerator
and then call BrowserWindow::ShowPasswordGenerationBubble using that generator.
This would make the PasswordGenerator code platform agnostic.

[zysxqn, 2012/05/31 21:54:08]

Why can't we create a PasswordGenerator directly here?

 #endif  // #if defined(OS_ANDROID)
 }
 
 void AutofillManager::RemoveAutofillProfileOrCreditCard(int unique_id) {
   const std::vector<AutofillProfile*>& profiles = personal_data_->profiles();
   const std::vector<CreditCard*>& credit_cards = personal_data_->credit_cards();
   const AutofillProfile* profile = NULL;
   const CreditCard* credit_card = NULL;
   size_t variant = 0;
   if (!GetProfileOrCreditCard(unique_id, profiles, credit_cards, &profile,
@@ skipping 645 matching lines @@
   *profile_guid = IDToGUID(profile_id);
 }
 
 void AutofillManager::UpdateInitialInteractionTimestamp(
     const TimeTicks& interaction_timestamp) {
   if (initial_interaction_timestamp_.is_null() ||
       interaction_timestamp < initial_interaction_timestamp_) {
     initial_interaction_timestamp_ = interaction_timestamp;
   }
 }