Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10458009: Add some temporary code to work around an error in test scripts, to fix buildbots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 61302ab9269bcf635f8c0b5a882cab7f8121fba8..1271c38ef9e3c303ee69ffb17ba489da13434f6e 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -730,6 +730,11 @@ class BatchRunnerProcess {
}
void _testCompleted() {
+ // TODO(whesse): Remove this temporary code used to diagnose problem.
Søren Gjesse 2012/05/29 09:11:56 If there is not already a bug on this please file
+ if (!_stdoutDrained || !_stderrDrained) {
+ print("Warning: Batch Test Runner problem:\n"
+ " _stdoutDrained: $_stdoutDrained, _stderrDrained: $_stderrDrained");
+ }
var test = _currentTest;
_currentTest = null;
test.completed();
@@ -742,9 +747,23 @@ class BatchRunnerProcess {
var exitCode = 0;
if (outcome == "CRASH") exitCode = -10;
if (outcome == "FAIL" || outcome == "TIMEOUT") exitCode = 1;
- new TestOutput.fromCase(_currentTest, exitCode, (outcome == "TIMEOUT"),
- _testStdout, _testStderr,
- new Date.now().difference(_startTime));
+ // TODO(whesse): Remove this temporary code used to diagnose problem.
+ if (_currentTest == null) {
+ print("Warning: Batch Test Runner problem:\n"
+ " _currentTest is null\n"
+ " Stdout:");
Søren Gjesse 2012/05/29 09:11:56 Tab character.
+ for (var line in _testStdout) {
+ print(line);
+ }
+ print(" Stderr:");
+ for (var line in _testStderr) {
+ print(line);
+ }
+ } else {
+ new TestOutput.fromCase(_currentTest, exitCode, (outcome == "TIMEOUT"),
+ _testStdout, _testStderr,
+ new Date.now().difference(_startTime));
+ }
// Move on when both stdout and stderr has been drained. If the test
// crashed, we restarted the process and therefore do not attempt to
// drain stderr.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698