Issue 10458009: Add some temporary code to work around an error in test scripts, to fix buildbots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10458009: Add some temporary code to work around an error in test scripts, to fix buildbots. (Closed)

Created:
8 years, 6 months ago by Bill Hesse

Modified:
8 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add some temporary code to work around an error in test scripts, to fix buildbots. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8043

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add Bug number 3286 to TODOs. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View	1	2 chunks	+22 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years, 6 months ago (2012-05-29 09:11:56 UTC) #2

lgtm

http://codereview.chromium.org/10458009/diff/1/tools/testing/dart/test_runner...
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/10458009/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:733: // TODO(whesse): Remove this temporary
code used to diagnose problem.
If there is not already a bug on this please file one and put a reference to it
here.

http://codereview.chromium.org/10458009/diff/1/tools/testing/dart/test_runner...
tools/testing/dart/test_runner.dart:754: "    Stdout:");
Tab character.

Expand Messages | Collapse Messages