ui: Rename the IDR constants to put hot/pressed state before position.

ui: Rename the IDR constants to put hot/pressed state before position.

Note: This was a TODO for @jamescook.

R=sky@chromium.org,jamescook@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140385

[oshima, 2012-06-01 00:48:07]

http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
File chrome/browser/ui/gtk/gtk_chrome_button.cc (right):

http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
chrome/browser/ui/gtk/gtk_chrome_button.cc:57: IDR_TEXTBUTTON_HOT_TOP_LEFT,
can you change this to IDR_TEXTBUTTON_HOVER_XXX ?

[tfarina, 2012-06-01 00:49:52]

On 2012/06/01 00:48:07, oshima wrote:
>
http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
> File chrome/browser/ui/gtk/gtk_chrome_button.cc (right):
> 
>
http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
> chrome/browser/ui/gtk/gtk_chrome_button.cc:57: IDR_TEXTBUTTON_HOT_TOP_LEFT,
> can you change this to IDR_TEXTBUTTON_HOVER_XXX ?

not sure, because the file name is textbutton_hot_bottom.png, etc...

[oshima, 2012-06-01 00:54:16]

We decided to use "hover" instead of hot because it can also mean active. I
thought I changed most of _hot_, but looks like I missed some. Can you rename
them as well?

On 2012/06/01 00:49:52, tfarina wrote:
> On 2012/06/01 00:48:07, oshima wrote:
> >
>
http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
> > File chrome/browser/ui/gtk/gtk_chrome_button.cc (right):
> > 
> >
>
http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
> > chrome/browser/ui/gtk/gtk_chrome_button.cc:57: IDR_TEXTBUTTON_HOT_TOP_LEFT,
> > can you change this to IDR_TEXTBUTTON_HOVER_XXX ?
> 
> not sure, because the file name is textbutton_hot_bottom.png, etc...

[tfarina, 2012-06-01 00:55:50]

On Thu, May 31, 2012 at 9:54 PM,  <oshima@chromium.org> wrote:
> We decided to use "hover" instead of hot because it can also mean active. I
> thought I changed most of _hot_, but looks like I missed some. Can you
> rename
> them as well?
>
You mean to rename the files in this CL? If there isn't any problems
with trybots and waterfall by doing this, then I can them in this CL.

-- 
Thiago

[oshima, 2012-06-01 01:02:47]

No, don't have to be in this CL.

- oshima

On Thu, May 31, 2012 at 5:55 PM, Thiago Farina <tfarina@chromium.org> wrote:

> On Thu, May 31, 2012 at 9:54 PM,  <oshima@chromium.org> wrote:
> > We decided to use "hover" instead of hot because it can also mean
> active. I
> > thought I changed most of _hot_, but looks like I missed some. Can you
> > rename
> > them as well?
> >
> You mean to rename the files in this CL? If there isn't any problems
> with trybots and waterfall by doing this, then I can them in this CL.
>
> --
> Thiago
>

[tfarina, 2012-06-02 01:34:48]

http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
File chrome/browser/ui/gtk/gtk_chrome_button.cc (right):

http://codereview.chromium.org/10456077/diff/1/chrome/browser/ui/gtk/gtk_chro...
chrome/browser/ui/gtk/gtk_chrome_button.cc:57: IDR_TEXTBUTTON_HOT_TOP_LEFT,
On 2012/06/01 00:48:07, oshima wrote:
> can you change this to IDR_TEXTBUTTON_HOVER_XXX ?

Done.

[tfarina, 2012-06-04 20:08:31]

ping??

[James Cook, 2012-06-04 21:20:27]

LGTM, sorry for the delay.

[oshima, 2012-06-04 21:25:54]

lgtm

On Mon, Jun 4, 2012 at 2:20 PM, <jamescook@chromium.org> wrote:

> LGTM, sorry for the delay.
>
>
http://codereview.chromium.**org/10456077/<http://codereview.chromium.org/104...
>

[sky, 2012-06-04 21:34:01]

LGTM