MessageLoopProxy cleanups in remoting client.

remoting/client/plugin/chromoting_scriptable_object.h

Index: remoting/client/plugin/chromoting_scriptable_object.h
diff --git a/remoting/client/plugin/chromoting_scriptable_object.h b/remoting/client/plugin/chromoting_scriptable_object.h
index acb8d635bdcc95a6b5789a4c5d741704a303f36f..272b1f4cd6b8b26f8c33944daa263408b0acbb1e 100644
--- a/remoting/client/plugin/chromoting_scriptable_object.h
+++ b/remoting/client/plugin/chromoting_scriptable_object.h
@@ -108,7 +108,7 @@
 #include "remoting/client/plugin/chromoting_instance.h"
 
 namespace base {
-class MessageLoopProxy;
+class SingleThreadTaskRunner;
 };  // namespace base
 
 namespace remoting {
@@ -121,7 +121,7 @@ class ChromotingScriptableObject
  public:
   ChromotingScriptableObject(
       ChromotingInstance* instance,

[Wez, 2012/05/26 00:18:40]

nit: Add a comment explaining that the instance must out-live the scriptable
object?

[Sergey Ulanov, 2012/05/30 01:07:07]

Done.

-      base::MessageLoopProxy* plugin_message_loop);
+      base::SingleThreadTaskRunner* plugin_task_runner);

[Wez, 2012/05/26 00:18:40]

nit: scoped_refptr<>?

[Wez, 2012/05/26 00:18:40]

nit: Clarify that we only need to pass the plugin TaskRunner here because each
plugin has its own TaskRunner, while plugins may share a main thread, so getting
the thread-current TaskRunner won't work?

[Wez, 2012/05/26 00:18:40]

ChromotingScriptableObject doesn't actually need a SingleThreadTaskRunner, just
a TaskRunner.

[Sergey Ulanov, 2012/05/30 01:07:07]

It assumes that the task runner runs all tasks on the plugin thread, so it's
still better to use SingleThreadTaskRunner here.

[Sergey Ulanov, 2012/05/30 01:07:07]

It's really necessary in case, though still might be good idea for readablity.
In any case, I think it's better to fix it in a separate CL - it's out of scope
for this one. 

[Sergey Ulanov, 2012/05/30 01:07:07]

Potentially we can set ThreadTaskRunnerHandle for ppapi plugin. We just don't do
it currently. In any case this code is going to go away soon, so no need to fix
it.

   virtual ~ChromotingScriptableObject();
 
   virtual void Init();
@@ -206,7 +206,7 @@ class ChromotingScriptableObject
 
   ChromotingInstance* instance_;
 
-  scoped_refptr<base::MessageLoopProxy> plugin_message_loop_;
+  scoped_refptr<base::SingleThreadTaskRunner> plugin_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingScriptableObject);
 };