MessageLoopProxy cleanups in remoting client.

remoting/client/plugin/chromoting_scriptable_object.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This implements the JavaScript class entrypoint for the plugin instance.
 // The Javascript API is defined as follows.
 //
 // interface ChromotingScriptableObject {
 //
 //   // Chromoting session API version (for this plugin).
@@ skipping 90 matching lines @@
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/memory/weak_ptr.h"
 #include "ppapi/cpp/dev/scriptable_object_deprecated.h"
 #include "ppapi/cpp/var.h"
 #include "remoting/client/plugin/chromoting_instance.h"
 
 namespace base {
-class MessageLoopProxy;
+class SingleThreadTaskRunner;
 };  // namespace base
 
 namespace remoting {
 
 // TODO(sergeyu): Remove this class when migration to messaging
 // interface is finished (crbug.com/86353).
 class ChromotingScriptableObject
     : public pp::deprecated::ScriptableObject,
       public base::SupportsWeakPtr<ChromotingScriptableObject> {
  public:
   ChromotingScriptableObject(
       ChromotingInstance* instance,

[Wez, 2012/05/26 00:18:40]

nit: Add a comment explaining that the instance must out-live the scriptable
object?

[Sergey Ulanov, 2012/05/30 01:07:07]

Done.

-      base::MessageLoopProxy* plugin_message_loop);
+      base::SingleThreadTaskRunner* plugin_task_runner);

[Wez, 2012/05/26 00:18:40]

nit: scoped_refptr<>?

[Wez, 2012/05/26 00:18:40]

nit: Clarify that we only need to pass the plugin TaskRunner here because each
plugin has its own TaskRunner, while plugins may share a main thread, so getting
the thread-current TaskRunner won't work?

[Wez, 2012/05/26 00:18:40]

ChromotingScriptableObject doesn't actually need a SingleThreadTaskRunner, just
a TaskRunner.

[Sergey Ulanov, 2012/05/30 01:07:07]

It assumes that the task runner runs all tasks on the plugin thread, so it's
still better to use SingleThreadTaskRunner here.

[Sergey Ulanov, 2012/05/30 01:07:07]

It's really necessary in case, though still might be good idea for readablity.
In any case, I think it's better to fix it in a separate CL - it's out of scope
for this one. 

[Sergey Ulanov, 2012/05/30 01:07:07]

Potentially we can set ThreadTaskRunnerHandle for ppapi plugin. We just don't do
it currently. In any case this code is going to go away soon, so no need to fix
it.

   virtual ~ChromotingScriptableObject();
 
   virtual void Init();
 
   // Override the ScriptableObject functions.
   virtual bool HasProperty(const pp::Var& name, pp::Var* exception) OVERRIDE;
   virtual bool HasMethod(const pp::Var& name, pp::Var* exception) OVERRIDE;
   virtual pp::Var GetProperty(const pp::Var& name, pp::Var* exception) OVERRIDE;
   virtual void GetAllPropertyNames(std::vector<pp::Var>* properties,
                                    pp::Var* exception) OVERRIDE;
@@ skipping 64 matching lines @@
   // This method is called by Javascript when the plugin loses input focus to
   // release all pressed keys.
   pp::Var DoReleaseAllKeys(const std::vector<pp::Var>& args,
                            pp::Var* exception);
 
   PropertyNameMap property_names_;
   std::vector<PropertyDescriptor> properties_;
 
   ChromotingInstance* instance_;
 
-  scoped_refptr<base::MessageLoopProxy> plugin_message_loop_;
+  scoped_refptr<base::SingleThreadTaskRunner> plugin_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingScriptableObject);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_PLUGIN_CHROMOTING_SCRIPTABLE_OBJECT_H_