fix crash when double-deleting a profile

fix crash when double-deleting a profile

this fixes both the UI (so it's impossible to trigger the crash) and skirts around the crash itself (which could potentially still be triggered via a UI race, i.e. if the user clicks fast enough).

BUG=129651
(maybe? not sure I understand that bug but this has a very similar stack signature)
TEST=create second profile. open delete dialog for that profile (don't delete yet). Go to profile 2 window, open settings. Open delete dialog for profile 2. Confirm delete of profile 2 on profile 2 window. Notice that the delete confirmation dialog in profile 1's window has now closed on its own.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139419

[Miranda Callahan, 2012-05-25 15:29:59]

On 2012/05/25 01:22:53, Evan Stade wrote:

Haven't touched this code in quite a while; sending over to Sailesh.

[sail, 2012-05-28 18:45:07]

LGTM
Sorry for the slow turn around.
binji: FYI

http://codereview.chromium.org/10453020/diff/1/chrome/browser/profiles/profil...
File chrome/browser/profiles/profile_info_cache.cc (right):

http://codereview.chromium.org/10453020/diff/1/chrome/browser/profiles/profil...
chrome/browser/profiles/profile_info_cache.cc:230: NOTREACHED();
Hm... I don't think this NOTREACHED() is going to be hit.

All of the getters go through ProfileInfoCache::GetInfoForProfileAtIndex() which
already has a DCHECK().

[Evan Stade, 2012-05-29 18:12:13]

http://codereview.chromium.org/10453020/diff/1/chrome/browser/profiles/profil...
File chrome/browser/profiles/profile_info_cache.cc (right):

http://codereview.chromium.org/10453020/diff/1/chrome/browser/profiles/profil...
chrome/browser/profiles/profile_info_cache.cc:230: NOTREACHED();
On 2012/05/28 18:45:07, sail wrote:
> Hm... I don't think this NOTREACHED() is going to be hit.
> 
> All of the getters go through ProfileInfoCache::GetInfoForProfileAtIndex()
which
> already has a DCHECK().

this seems safer in case the code ever changes, so I'd rather leave it unless
you feel strongly.

[sail, 2012-05-29 18:38:21]

http://codereview.chromium.org/10453020/diff/1/chrome/browser/profiles/profil...
File chrome/browser/profiles/profile_info_cache.cc (right):

http://codereview.chromium.org/10453020/diff/1/chrome/browser/profiles/profil...
chrome/browser/profiles/profile_info_cache.cc:230: NOTREACHED();
On 2012/05/29 18:12:13, Evan Stade wrote:
> On 2012/05/28 18:45:07, sail wrote:
> > Hm... I don't think this NOTREACHED() is going to be hit.
> > 
> > All of the getters go through ProfileInfoCache::GetInfoForProfileAtIndex()
> which
> > already has a DCHECK().
> 
> this seems safer in case the code ever changes, so I'd rather leave it unless
> you feel strongly.

makes sense!