Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Unified Diff: net/spdy/spdy_stream_spdy3_unittest.cc

Issue 10448083: Fix out of order SYN_STEAM frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address willchan's comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_stream_spdy3_unittest.cc
diff --git a/net/spdy/spdy_stream_spdy3_unittest.cc b/net/spdy/spdy_stream_spdy3_unittest.cc
index 5d0188934c32b09bf59ca77922e0b93cfb624d9a..5eda408bddf96d4cfcb55da8e533effabdb9c9e1 100644
--- a/net/spdy/spdy_stream_spdy3_unittest.cc
+++ b/net/spdy/spdy_stream_spdy3_unittest.cc
@@ -275,9 +275,9 @@ TEST_F(SpdyStreamSpdy3Test, PushedStream) {
// Conjure up a stream.
scoped_refptr<SpdyStream> stream = new SpdyStream(spdy_session,
- 2,
true,
net_log);
+ stream->set_stream_id(2);
EXPECT_FALSE(stream->response_received());
EXPECT_FALSE(stream->HasUrl());
@@ -409,10 +409,10 @@ TEST_F(SpdyStreamSpdy3Test, StreamError) {
EXPECT_EQ(ERR_IO_PENDING, stream->SendRequest(true));
- const SpdyStreamId stream_id = stream->stream_id();
-
EXPECT_EQ(OK, callback.WaitForResult());
+ const SpdyStreamId stream_id = stream->stream_id();
+
EXPECT_TRUE(delegate->send_headers_completed());
EXPECT_EQ("200", (*delegate->response())[":status"]);
EXPECT_EQ("HTTP/1.1", (*delegate->response())[":version"]);

Powered by Google App Engine
This is Rietveld 408576698