Fix out of order SYN_STEAM frames.

net/spdy/spdy_stream_spdy3_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ref_counted.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_log_unittest.h"
 #include "net/spdy/buffered_spdy_framer.h"
 #include "net/spdy/spdy_stream.h"
 #include "net/spdy/spdy_http_utils.h"
@@ skipping 257 matching lines @@
   EXPECT_EQ(OK, connection->Init(host_port_pair.ToString(), transport_params,
                                  LOWEST, CompletionCallback(),
                                  session_->GetTransportSocketPool(
                                      HttpNetworkSession::NORMAL_SOCKET_POOL),
                                  BoundNetLog()));
   spdy_session->InitializeWithSocket(connection.release(), false, OK);
   BoundNetLog net_log;
 
   // Conjure up a stream.
   scoped_refptr<SpdyStream> stream = new SpdyStream(spdy_session,
-                                                    2,
                                                     true,
                                                     net_log);
+  stream->set_stream_id(2);
   EXPECT_FALSE(stream->response_received());
   EXPECT_FALSE(stream->HasUrl());
 
   // Set a couple of headers.
   SpdyHeaderBlock response;
   GURL url(kStreamUrl);
   response[":host"] = url.host();
   response[":scheme"] = url.scheme();
   response[":path"] = url.path();
   stream->OnResponseReceived(response);
@@ skipping 111 matching lines @@
   (*headers)[":scheme"] = url.scheme();
   (*headers)[":host"] = url.host();
   (*headers)[":path"] = url.path();
   (*headers)[":version"] = "HTTP/1.1";
   stream->set_spdy_headers(headers);
   EXPECT_TRUE(stream->HasUrl());
   EXPECT_EQ(kStreamUrl, stream->GetUrl().spec());
 
   EXPECT_EQ(ERR_IO_PENDING, stream->SendRequest(true));
 
+  EXPECT_EQ(OK, callback.WaitForResult());
+
   const SpdyStreamId stream_id = stream->stream_id();
 
-  EXPECT_EQ(OK, callback.WaitForResult());
-
   EXPECT_TRUE(delegate->send_headers_completed());
   EXPECT_EQ("200", (*delegate->response())[":status"]);
   EXPECT_EQ("HTTP/1.1", (*delegate->response())[":version"]);
   EXPECT_EQ(std::string("\0hello!\xff", 8), delegate->received_data());
   EXPECT_EQ(8, delegate->data_sent());
   EXPECT_TRUE(delegate->closed());
 
   // Check that the NetLog was filled reasonably.
   net::CapturingNetLog::EntryList entries;
   log.GetEntries(&entries);
   EXPECT_LT(0u, entries.size());
 
   // Check that we logged SPDY_STREAM_ERROR correctly.
   int pos = net::ExpectLogContainsSomewhere(
       entries, 0,
       net::NetLog::TYPE_SPDY_STREAM_ERROR,
       net::NetLog::PHASE_NONE);
 
   CapturingNetLog::Entry entry = entries[pos];
   NetLogSpdyStreamErrorParameter* request_params =
       static_cast<NetLogSpdyStreamErrorParameter*>(
           entry.extra_parameters.get());
   EXPECT_EQ(stream_id, request_params->stream_id());
 }
 
 }  // namespace net