Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: ui/web_dialogs/web_dialog_delegate.h

Issue 10448066: Move the web dialogs code to src/ui/web_dialogs from src/chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/web_dialogs/web_dialog_delegate.h
diff --git a/chrome/browser/ui/webui/web_dialog_delegate.h b/ui/web_dialogs/web_dialog_delegate.h
similarity index 93%
rename from chrome/browser/ui/webui/web_dialog_delegate.h
rename to ui/web_dialogs/web_dialog_delegate.h
index 12ebadaca160c5c73ce3e1e084e4872afa13a181..0a46e0468a8d6d17c0f1a4dd5f901443c0c9c080 100644
--- a/chrome/browser/ui/webui/web_dialog_delegate.h
+++ b/ui/web_dialogs/web_dialog_delegate.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_WEBUI_WEB_DIALOG_DELEGATE_H_
-#define CHROME_BROWSER_UI_WEBUI_WEB_DIALOG_DELEGATE_H_
+#ifndef UI_WEB_DIALOGS_WEB_DIALOG_DELEGATE_H_
+#define UI_WEB_DIALOGS_WEB_DIALOG_DELEGATE_H_
#pragma once
#include <string>
@@ -11,6 +11,7 @@
#include "base/string16.h"
#include "ui/base/ui_base_types.h"
+#include "ui/web_dialogs/web_dialogs_export.h"
#include "webkit/glue/window_open_disposition.h"
class GURL;
@@ -29,11 +30,13 @@ class Rect;
class Size;
}
+namespace ui {
+
// Implement this class to receive notifications.
-class WebDialogDelegate {
+class WEB_DIALOGS_EXPORT WebDialogDelegate {
tfarina 2012/05/30 19:14:19 nit: I bet you can remove WEB_DIALOGS_EXPORT. But
mazda 2012/05/30 20:14:12 It's necessary for HandleContextMenu, HandleOpenUR
public:
// Returns true if the contents needs to be run in a modal dialog.
- virtual ui::ModalType GetDialogModalType() const = 0;
+ virtual ModalType GetDialogModalType() const = 0;
// Returns the title of the dialog.
virtual string16 GetDialogTitle() const = 0;
@@ -119,5 +122,6 @@ class WebDialogDelegate {
virtual ~WebDialogDelegate() {}
};
+} // namespace ui
-#endif // CHROME_BROWSER_UI_WEBUI_WEB_DIALOG_DELEGATE_H_
+#endif // UI_WEB_DIALOGS_WEB_DIALOG_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698