Move the web dialogs code to src/ui/web_dialogs from src/chrome

ui/web_dialogs/web_dialog_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_UI_WEBUI_WEB_DIALOG_DELEGATE_H_
-#define CHROME_BROWSER_UI_WEBUI_WEB_DIALOG_DELEGATE_H_
+#ifndef UI_WEB_DIALOGS_WEB_DIALOG_DELEGATE_H_
+#define UI_WEB_DIALOGS_WEB_DIALOG_DELEGATE_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/string16.h"
 #include "ui/base/ui_base_types.h"
+#include "ui/web_dialogs/web_dialogs_export.h"
 #include "webkit/glue/window_open_disposition.h"
 
 class GURL;
 
 namespace content {
 class RenderViewHost;
 class WebContents;
 class WebUI;
 class WebUIMessageHandler;
 struct ContextMenuParams;
 struct OpenURLParams;
 }
 
 namespace gfx {
 class Rect;
 class Size;
 }
 
+namespace ui {
+
 // Implement this class to receive notifications.
-class WebDialogDelegate {
+class WEB_DIALOGS_EXPORT WebDialogDelegate {

[tfarina, 2012/05/30 19:14:19]

nit: I bet you can remove WEB_DIALOGS_EXPORT. But I'm fine in keep it as it's
consistent across ui/

[mazda, 2012/05/30 20:14:12]

It's necessary for HandleContextMenu, HandleOpenURLFromTab etc.

  public:
   // Returns true if the contents needs to be run in a modal dialog.
-  virtual ui::ModalType GetDialogModalType() const = 0;
+  virtual ModalType GetDialogModalType() const = 0;
 
   // Returns the title of the dialog.
   virtual string16 GetDialogTitle() const = 0;
 
   // Returns the dialog's name identifier. Used to identify this dialog for
   // state restoration.
   virtual std::string GetDialogName() const;
 
   // Get the HTML file path for the content to load in the dialog.
   virtual GURL GetDialogContentURL() const = 0;
@@ skipping 38 matching lines @@
                                bool* out_close_dialog) = 0;
 
   // A callback to allow the delegate to dictate that the window should not
   // have a title bar.  This is useful when presenting branded interfaces.
   virtual bool ShouldShowDialogTitle() const = 0;
 
   // A callback to allow the delegate to inhibit context menu or show
   // customized menu.
   // Returns true iff you do NOT want the standard context menu to be
   // shown (because you want to handle it yourself).
   virtual bool HandleContextMenu(const content::ContextMenuParams& params);

[tfarina, 2012/05/30 19:14:19]

This doesn't have any implementations. Can you add {} here and in
HandleAddNewContents too? 

[mazda, 2012/05/30 20:14:12]

The implementations were left in web_dialog_ui.cc in the process of extracting
WebDialogDelegate in your change (http://crrev.com/135085). :)
Since it is not allowed for virtual methods to have non-empty inline body
(http://www.chromium.org/developers/coding-style/chromium-style-checker-errors),
I created web_dialog_delegate.cc and moved the implementations from
web_dialog_ui.cc.

 
   // A callback to allow the delegate to open a new URL inside |source|.
   // On return |out_new_contents| should contain the WebContents the URL
   // is opened in. Return false to use the default handler.
   virtual bool HandleOpenURLFromTab(content::WebContents* source,
                                     const content::OpenURLParams& params,
                                     content::WebContents** out_new_contents);
 
   // A callback to create a new tab with |new_contents|. |source| is the
   // WebContent where the operation originated. |disposition| controls how the
   // new tab should be opened. |initial_pos| is the position of the window if a
   // new window is created. |user_gesture| is true if the operation was started
   // by a user gesture. Return false to use the default handler.
   virtual bool HandleAddNewContents(content::WebContents* source,
                                     content::WebContents* new_contents,
                                     WindowOpenDisposition disposition,
                                     const gfx::Rect& initial_pos,
                                     bool user_gesture);
 
   // Stores the dialog bounds.
   virtual void StoreDialogSize(const gfx::Size& dialog_size) {}
 
  protected:
   virtual ~WebDialogDelegate() {}
 };
 
+}  // namespace ui
 
-#endif  // CHROME_BROWSER_UI_WEBUI_WEB_DIALOG_DELEGATE_H_
+#endif  // UI_WEB_DIALOGS_WEB_DIALOG_DELEGATE_H_