Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 10447096: Fix webview example in views examples. (Closed)

Created:
8 years, 6 months ago by rkc
Modified:
8 years, 6 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org, jam
Visibility:
Public.

Description

Fix view view in views examples. The views delegate used in Views Examples derives from TestViewsDelegate, which returns a TestWebContents when WebView tries to create it's webcontents. Since this functionality is intended only for unit tests, moved the test webcontents creation to a subclass of TestViewsDelegate in ash_test_base. This leaves TestViewsDelegate and it's subclasses unaffected. R=ben@chromium.org BUG=None. TEST=Ran aura_test_unittests and verified that the webview example in views examples through ash_shell works correctly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139690 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139704

Patch Set 1 #

Patch Set 2 : cros clang fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M ash/screensaver/screensaver_view_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rkc
8 years, 6 months ago (2012-05-30 21:05:05 UTC) #1
Ben Goodger (Google)
what about views examples built on windows non-ash?
8 years, 6 months ago (2012-05-30 21:22:58 UTC) #2
rkc
On 2012/05/30 21:22:58, Ben Goodger (Google) wrote: > what about views examples built on windows ...
8 years, 6 months ago (2012-05-30 21:27:28 UTC) #3
Ben Goodger (Google)
ok, lgtm. i'll leave it to jam to verify. On Wed, May 30, 2012 at ...
8 years, 6 months ago (2012-05-30 21:27:54 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-05-30 21:53:02 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698