Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10447083: Rename webkit_blob::FileReader to FileStreamReader. (Closed)

Created:
8 years, 6 months ago by kinaba
Modified:
8 years, 6 months ago
Reviewers:
ericu, kinuko
CC:
chromium-reviews, stevenjb+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Rename webkit_blob::FileReader to FileStreamReader. The name was confusion: it does not directly correspond to FileReader in File API, (which is implemented by WebCore::FileReader). BUG=128483 TEST=Existing file/blob tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139724

Patch Set 1 : #

Total comments: 2

Patch Set 2 : merge master branch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -885 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/blob_url_request_job.h View 4 chunks +5 lines, -6 lines 0 comments Download
M webkit/blob/blob_url_request_job.cc View 6 chunks +8 lines, -7 lines 0 comments Download
D webkit/blob/file_reader.h View 1 chunk +0 lines, -47 lines 0 comments Download
A + webkit/blob/file_stream_reader.h View 3 chunks +5 lines, -6 lines 0 comments Download
D webkit/blob/local_file_reader.h View 1 chunk +0 lines, -89 lines 0 comments Download
D webkit/blob/local_file_reader.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D webkit/blob/local_file_reader_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
A + webkit/blob/local_file_stream_reader.h View 4 chunks +16 lines, -12 lines 0 comments Download
A + webkit/blob/local_file_stream_reader.cc View 8 chunks +27 lines, -24 lines 0 comments Download
A + webkit/blob/local_file_stream_reader_unittest.cc View 14 chunks +24 lines, -24 lines 0 comments Download
M webkit/blob/webkit_blob.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D webkit/fileapi/file_system_file_reader.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webkit/fileapi/file_system_file_reader.cc View 1 chunk +0 lines, -98 lines 0 comments Download
A + webkit/fileapi/file_system_file_stream_reader.h View 4 chunks +13 lines, -13 lines 0 comments Download
A + webkit/fileapi/file_system_file_stream_reader.cc View 8 chunks +15 lines, -14 lines 0 comments Download
M webkit/fileapi/file_system_mount_point_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/fileapi/sandbox_file_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
FileReader part of the rename. Please take a look. Thanks!
8 years, 6 months ago (2012-05-30 09:31:26 UTC) #1
kinuko
LGTM thanks! http://codereview.chromium.org/10447083/diff/2001/webkit/chromeos/fileapi/cros_mount_point_provider.cc File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right): http://codereview.chromium.org/10447083/diff/2001/webkit/chromeos/fileapi/cros_mount_point_provider.cc#newcode264 webkit/chromeos/fileapi/cros_mount_point_provider.cc:264: return new fileapi::FileSystemFileStreamReader(context, url, offset); Oops this ...
8 years, 6 months ago (2012-05-30 14:34:36 UTC) #2
ericu
lgtm
8 years, 6 months ago (2012-05-30 17:42:14 UTC) #3
kinaba
http://codereview.chromium.org/10447083/diff/2001/webkit/chromeos/fileapi/cros_mount_point_provider.cc File webkit/chromeos/fileapi/cros_mount_point_provider.cc (right): http://codereview.chromium.org/10447083/diff/2001/webkit/chromeos/fileapi/cros_mount_point_provider.cc#newcode264 webkit/chromeos/fileapi/cros_mount_point_provider.cc:264: return new fileapi::FileSystemFileStreamReader(context, url, offset); On 2012/05/30 14:34:36, kinuko ...
8 years, 6 months ago (2012-05-31 01:35:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10447083/3002
8 years, 6 months ago (2012-05-31 01:36:13 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 03:16:02 UTC) #6 
Change committed as 139724

Powered by Google App Engine
This is Rietveld 408576698