Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10446095: Move ProgramCompare from setup_util to install_util. (Closed)

Created:
8 years, 6 months ago by gab
Modified:
8 years, 6 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Move ProgramCompare from setup_util to install_util. ...and switch to oh so ever beautiful string16s. BUG=None TEST=setup_util_unittests installer_util_unittests --gtest_filter=InstallUtilTest.ProgramCompare Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139837

Patch Set 1 #

Patch Set 2 : and make it compile with current master.. #

Total comments: 1

Patch Set 3 : diff with master this time...(if that makes a difference..?) #

Total comments: 4

Patch Set 4 : move tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -184 lines) Patch
M chrome/installer/setup/setup_util.h View 1 2 3 3 chunks +1 line, -27 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 2 3 2 chunks +1 line, -71 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 2 3 2 chunks +1 line, -48 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/install_util.h View 6 chunks +41 lines, -16 lines 0 comments Download
M chrome/installer/util/install_util.cc View 12 chunks +88 lines, -18 lines 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 1 2 3 3 chunks +47 lines, -1 line 1 comment Download

Messages

Total messages: 8 (0 generated)
gab
As suggested at: https://chromiumcodereview.appspot.com/10451074/diff/1007/chrome/installer/util/shell_util.cc#newcode692
8 years, 6 months ago (2012-05-31 04:40:35 UTC) #1
gab
FYI, see below. http://codereview.chromium.org/10446095/diff/2001/chrome/installer/setup/setup_util.cc File chrome/installer/setup/setup_util.cc (right): http://codereview.chromium.org/10446095/diff/2001/chrome/installer/setup/setup_util.cc#newcode15 chrome/installer/setup/setup_util.cc:15: #include "third_party/bspatch/mbspatch.h" FYI: I tested all ...
8 years, 6 months ago (2012-05-31 04:42:42 UTC) #2
grt (UTC plus 2)
Looks good. Please move the unit test from setup into util as well. http://codereview.chromium.org/10446095/diff/7003/chrome/installer/setup/setup_util.cc File ...
8 years, 6 months ago (2012-05-31 12:56:03 UTC) #3
gab
Done. http://codereview.chromium.org/10446095/diff/7003/chrome/installer/setup/setup_util.cc File chrome/installer/setup/setup_util.cc (right): http://codereview.chromium.org/10446095/diff/7003/chrome/installer/setup/setup_util.cc#newcode1 chrome/installer/setup/setup_util.cc:1: // Copyright (c) 2011 The Chromium Authors. All ...
8 years, 6 months ago (2012-05-31 16:27:24 UTC) #4
gab
http://codereview.chromium.org/10446095/diff/8003/chrome/installer/util/install_util_unittest.cc File chrome/installer/util/install_util_unittest.cc (right): http://codereview.chromium.org/10446095/diff/8003/chrome/installer/util/install_util_unittest.cc#newcode404 chrome/installer/util/install_util_unittest.cc:404: } Ends by 0A 7D 0A so rietveld's lint ...
8 years, 6 months ago (2012-05-31 16:32:05 UTC) #5
grt (UTC plus 2)
lgtm
8 years, 6 months ago (2012-05-31 16:56:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10446095/8003
8 years, 6 months ago (2012-05-31 17:03:11 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 19:25:37 UTC) #8 
Change committed as 139837

Powered by Google App Engine
This is Rietveld 408576698