Fixing the focus issue in open/save dialogs.

chrome/browser/ui/views/extensions/extension_dialog.cc

Index: chrome/browser/ui/views/extensions/extension_dialog.cc
diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc
index e9f9f032d3ae88e05a97517fcff5297567b2b48b..9acc099f78d11cf8c60328ed7bcb02d2766d6176 100644
--- a/chrome/browser/ui/views/extensions/extension_dialog.cc
+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc
@@ -192,6 +192,11 @@ void ExtensionDialog::MaybeFocusRenderView() {
   if (!view)
     return;
 
+  // TODO(oshima): Views + aura doesn't seem to update the views focus
+  // manager when an aura window gets focus. This is a workaround for
+  // this issue. Fix it this and remove this workaround.
+  // See bug.com/127222.
+  focus_manager->SetFocusedView(GetContentsView());

[Ben Goodger (Google), 2012/07/11 16:06:38]

So who's going to fix the underlying issue?

[SeRya, 2012/07/11 16:39:44]

@oshima

   view->Focus();

[sky, 2012/06/28 22:47:51]

I have a feeling views doesn't get focus because NativeViewHost doesn't know who
to give focus to when the aura::Window gets focus. Try set_focus_view on
ExtensionView (which is a NativeViewHost).

[SeRya, 2012/06/29 09:35:55]

ExtensionView does have focused view (host->view()->focus_view() != NULL in
ShowInternal, set_focus_view doesn't help) but the focus manager anyway has NULL
in focused_view_. So the real problem is somewhere else.

 }