Fixing the focus issue in open/save dialogs.

chrome/browser/ui/views/extensions/extension_dialog.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_dialog.h"
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 174 matching lines @@
 void ExtensionDialog::MaybeFocusRenderView() {
   views::FocusManager* focus_manager = GetWidget()->GetFocusManager();
   // Already there's a focused view, so no need to switch the focus.
   if (focus_manager && focus_manager->GetFocusedView())
     return;
 
   content::RenderWidgetHostView* view = host()->render_view_host()->GetView();
   if (!view)
     return;
 
+  // TODO(oshima): Views + aura doesn't seem to update the views focus
+  // manager when an aura window gets focus. This is a workaround for
+  // this issue. Fix it this and remove this workaround.
+  // See bug.com/127222.
+  focus_manager->SetFocusedView(GetContentsView());

[Ben Goodger (Google), 2012/07/11 16:06:38]

So who's going to fix the underlying issue?

[SeRya, 2012/07/11 16:39:44]

@oshima

   view->Focus();

[sky, 2012/06/28 22:47:51]

I have a feeling views doesn't get focus because NativeViewHost doesn't know who
to give focus to when the aura::Window gets focus. Try set_focus_view on
ExtensionView (which is a NativeViewHost).

[SeRya, 2012/06/29 09:35:55]

ExtensionView does have focused view (host->view()->focus_view() != NULL in
ShowInternal, set_focus_view doesn't help) but the focus manager anyway has NULL
in focused_view_. So the real problem is somewhere else.

 }
 
 /////////////////////////////////////////////////////////////////////////////
 // views::WidgetDelegate overrides.
 
 bool ExtensionDialog::CanResize() const {
   return false;
 }
 
 ui::ModalType ExtensionDialog::GetModalType() const {
@@ skipping 56 matching lines @@
       if (content::Details<ExtensionHost>(host()) != details)
         return;
       if (observer_)
         observer_->ExtensionTerminated(this);
       break;
     default:
       NOTREACHED() << L"Received unexpected notification";
       break;
   }
 }