Report syntax errors in natives when building with mksnapshot.

src/api.cc

Index: src/api.cc
===================================================================
--- src/api.cc	(revision 11679)
+++ src/api.cc	(working copy)
@@ -1666,6 +1666,21 @@
 }
 
 
+// This doesn't actually use the serializer for anything, it's just a token
+// to get the special constructor that is only intended for mksnapshot.
+v8::TryCatch::TryCatch(const i::Serializer* serializer)
+    : isolate_(i::Isolate::Current()),
+      next_(isolate_->try_catch_handler_address()),
+      exception_(i::Smi::FromInt(0)),

[ulan, 2012/05/31 08:48:52]

Why is exception_ = 0 here, instead of the hole?
try_catch.HasCaught() seems to be always true in mksnapshot.cc since it checks
for the hole.

[Erik Corry, 2012/05/31 12:25:17]

Well spotted.

It turns out that I can just test the return value for IsEmpty and get rid of
the ugly special TryCatch constructor.

+      message_(i::Smi::FromInt(0)),
+      is_verbose_(false),
+      can_continue_(true),
+      capture_message_(true),
+      rethrow_(false) {
+  isolate_->RegisterTryCatchHandler(this);
+}
+
+
 v8::TryCatch::~TryCatch() {
   ASSERT(isolate_ == i::Isolate::Current());
   if (rethrow_) {