Report syntax errors in natives when building with mksnapshot.

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1648 matching lines @@
       exception_(isolate_->heap()->the_hole_value()),
       message_(i::Smi::FromInt(0)),
       is_verbose_(false),
       can_continue_(true),
       capture_message_(true),
       rethrow_(false) {
   isolate_->RegisterTryCatchHandler(this);
 }
 
 
+// This doesn't actually use the serializer for anything, it's just a token
+// to get the special constructor that is only intended for mksnapshot.
+v8::TryCatch::TryCatch(const i::Serializer* serializer)
+    : isolate_(i::Isolate::Current()),
+      next_(isolate_->try_catch_handler_address()),
+      exception_(i::Smi::FromInt(0)),

[ulan, 2012/05/31 08:48:52]

Why is exception_ = 0 here, instead of the hole?
try_catch.HasCaught() seems to be always true in mksnapshot.cc since it checks
for the hole.

[Erik Corry, 2012/05/31 12:25:17]

Well spotted.

It turns out that I can just test the return value for IsEmpty and get rid of
the ugly special TryCatch constructor.

+      message_(i::Smi::FromInt(0)),
+      is_verbose_(false),
+      can_continue_(true),
+      capture_message_(true),
+      rethrow_(false) {
+  isolate_->RegisterTryCatchHandler(this);
+}
+
+
 v8::TryCatch::~TryCatch() {
   ASSERT(isolate_ == i::Isolate::Current());
   if (rethrow_) {
     v8::HandleScope scope;
     v8::Local<v8::Value> exc = v8::Local<v8::Value>::New(Exception());
     isolate_->UnregisterTryCatchHandler(this);
     v8::ThrowException(exc);
   } else {
     isolate_->UnregisterTryCatchHandler(this);
   }
@@ skipping 4703 matching lines @@
 
 
 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
   HandleScopeImplementer* scope_implementer =
       reinterpret_cast<HandleScopeImplementer*>(storage);
   scope_implementer->IterateThis(v);
   return storage + ArchiveSpacePerThread();
 }
 
 } }  // namespace v8::internal