Chromium Code Reviews| Index: net/url_request/url_request_throttler_entry.h |
| diff --git a/net/url_request/url_request_throttler_entry.h b/net/url_request/url_request_throttler_entry.h |
| index 3ebd5c9ccb65f42c117d36686cd5b019b1f70c76..7d8f1337e87bcf4cbf992a0af5fe0940c59dbe8a 100644 |
| --- a/net/url_request/url_request_throttler_entry.h |
| +++ b/net/url_request/url_request_throttler_entry.h |
| @@ -93,7 +93,8 @@ class NET_EXPORT URLRequestThrottlerEntry |
| void DetachManager(); |
| // Implementation of URLRequestThrottlerEntryInterface. |
| - virtual bool ShouldRejectRequest(int load_flags) const OVERRIDE; |
| + virtual bool ShouldRejectRequest(const URLRequest* request, |
| + int load_flags) const OVERRIDE; |
|
eroman
2012/06/06 04:52:11
Is the load_flags parameter needed anymore? (since
Jói
2012/06/06 13:38:55
You're right, removed.
|
| virtual int64 ReserveSendingTimeForNextRequest( |
| const base::TimeTicks& earliest_time) OVERRIDE; |
| virtual base::TimeTicks GetExponentialBackoffReleaseTime() const OVERRIDE; |
| @@ -118,10 +119,6 @@ class NET_EXPORT URLRequestThrottlerEntry |
| void HandleThrottlingHeader(const std::string& header_value, |
| const std::string& host); |
| - // Used internally to keep track of failure->success transitions and |
| - // generate statistics about them. |
| - void HandleMetricsTracking(int response_code); |
| - |
| // Retrieves the back-off entry object we're using. Used to enable a |
| // unit testing seam for dependency injection in tests. |
| virtual const BackoffEntry* GetBackoffEntry() const; |
| @@ -164,15 +161,6 @@ class NET_EXPORT URLRequestThrottlerEntry |
| // Access it through GetBackoffEntry() to allow a unit test seam. |
| BackoffEntry backoff_entry_; |
| - // The time of the last successful response, plus knowledge of whether |
| - // the last response was successful or not, let us generate statistics on |
| - // the length of perceived downtime for a given URL, and the error count |
| - // when such transitions occur. This is useful for experiments with |
| - // throttling but will likely become redundant after they are finished. |
| - // TODO(joi): Remove when the time is right |
| - base::TimeTicks last_successful_response_time_; |
| - bool last_response_was_success_; |
| - |
| // Weak back-reference to the manager object managing us. |
| URLRequestThrottlerManager* manager_; |