Introduce a delegate to avoid hardcoding "chrome-extension" in net/.

net/url_request/url_request_throttler_entry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_THROTTLER_ENTRY_H_
 #define NET_URL_REQUEST_URL_REQUEST_THROTTLER_ENTRY_H_
 #pragma once
 
 #include <queue>
 #include <string>
@@ skipping 75 matching lines @@
   // collected.
   bool IsEntryOutdated() const;
 
   // Causes this entry to never reject requests due to back-off.
   void DisableBackoffThrottling();
 
   // Causes this entry to NULL its manager pointer.
   void DetachManager();
 
   // Implementation of URLRequestThrottlerEntryInterface.
-  virtual bool ShouldRejectRequest(int load_flags) const OVERRIDE;
+  virtual bool ShouldRejectRequest(const URLRequest* request,
+                                   int load_flags) const OVERRIDE;

[eroman, 2012/06/06 04:52:11]

Is the load_flags parameter needed anymore? (since it is part of |request|).

[Jói, 2012/06/06 13:38:55]

You're right, removed.

   virtual int64 ReserveSendingTimeForNextRequest(
       const base::TimeTicks& earliest_time) OVERRIDE;
   virtual base::TimeTicks GetExponentialBackoffReleaseTime() const OVERRIDE;
   virtual void UpdateWithResponse(
       const std::string& host,
       const URLRequestThrottlerHeaderInterface* response) OVERRIDE;
   virtual void ReceivedContentWasMalformed(int response_code) OVERRIDE;
 
  protected:
   virtual ~URLRequestThrottlerEntry();
 
   void Initialize();
 
   // Returns true if the given response code is considered an error for
   // throttling purposes.
   bool IsConsideredError(int response_code);
 
   // Equivalent to TimeTicks::Now(), virtual to be mockable for testing purpose.
   virtual base::TimeTicks ImplGetTimeNow() const;
 
   // Used internally to handle the opt-out header.
   void HandleThrottlingHeader(const std::string& header_value,
                               const std::string& host);
 
-  // Used internally to keep track of failure->success transitions and
-  // generate statistics about them.
-  void HandleMetricsTracking(int response_code);
-
   // Retrieves the back-off entry object we're using. Used to enable a
   // unit testing seam for dependency injection in tests.
   virtual const BackoffEntry* GetBackoffEntry() const;
   virtual BackoffEntry* GetBackoffEntry();
 
   // Returns true if |load_flags| contains a flag that indicates an
   // explicit request by the user to load the resource. We never
   // throttle requests with such load flags.
   static bool ExplicitUserRequest(const int load_flags);
 
@@ skipping 22 matching lines @@
 
   const base::TimeDelta sliding_window_period_;
   const int max_send_threshold_;
 
   // True if DisableBackoffThrottling() has been called on this object.
   bool is_backoff_disabled_;
 
   // Access it through GetBackoffEntry() to allow a unit test seam.
   BackoffEntry backoff_entry_;
 
-  // The time of the last successful response, plus knowledge of whether
-  // the last response was successful or not, let us generate statistics on
-  // the length of perceived downtime for a given URL, and the error count
-  // when such transitions occur. This is useful for experiments with
-  // throttling but will likely become redundant after they are finished.
-  // TODO(joi): Remove when the time is right
-  base::TimeTicks last_successful_response_time_;
-  bool last_response_was_success_;
-
   // Weak back-reference to the manager object managing us.
   URLRequestThrottlerManager* manager_;
 
   // Canonicalized URL string that this entry is for; used for logging only.
   std::string url_id_;
 
   BoundNetLog net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestThrottlerEntry);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_THROTTLER_ENTRY_H_