SpeechInputExtensionManager now interface (exclusively) with SpeechRecognitionManagerDelegate (Spee…

SpeechInputExtensionManager now interface (exclusively) with SpeechRecognitionManagerDelegate (Speech CL1.11)

This is a re-submit of r138498 which was reverted in 
r138568.

Fixes introduced by this CL:
- Added a check on speech_input_extensions_manager shutdown to assert that the speech_recognition_manager has not been unexpectedly destroyed (happens in some tests).
- Added WeakPtr to  speech_recognition_manager_impl so that it can be destroyed ungracefully without crashing.

Original CL description:
- The tray icon and balloon handing has been moved from speech_input_extensions_manager to chrome_speech_recognition_manager_delegate, since that code (tray icon) will be used also for continuous recognition. 
- Removed the SpeechRecognizer interface from /content/public (thus de-virtualized and refcounted the SpeechRecognizerImpl) 


BUG=116954, 129408
TEST=browser_tests on Linux ChromiumOS (dbg)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138765

[Satish, 2012-05-24 09:50:44]

lgtm with nits

http://codereview.chromium.org/10440011/diff/3001/chrome/browser/speech/speec...
File chrome/browser/speech/speech_input_extension_manager.cc (right):

http://codereview.chromium.org/10440011/diff/3001/chrome/browser/speech/speec...
chrome/browser/speech/speech_input_extension_manager.cc:214: void
SpeechInputExtensionManager::UnregisterFromManagerOnIOThread() {
UnregisterFromManager is a bit confusing since this class is also named as a
Manager :) Can we rename this to AbortAllSessionsInIOThread ?

http://codereview.chromium.org/10440011/diff/3001/chrome/browser/speech/speec...
chrome/browser/speech/speech_input_extension_manager.cc:220: // envisaged by
browser_main_loop, causing a crash on this line.
'causing a crash on this line' -> 'so SpeechRecognitionmanager could have been
freed by now'

[hans, 2012-05-24 09:57:08]

lgtm, but please update the CL description to highlight the differences between
this and the original CL, and also point to the bug with the chromeos crash (it
should be in the BUG= field too).

Since this diff (compared to the original CL) only touches the
chrome/browser/speech/ directory, I don't think we need to wait for owners
approval from the others on this.

[Primiano Tucci (use gerrit), 2012-05-24 10:14:06]

http://codereview.chromium.org/10440011/diff/3001/chrome/browser/speech/speec...
File chrome/browser/speech/speech_input_extension_manager.cc (right):

http://codereview.chromium.org/10440011/diff/3001/chrome/browser/speech/speec...
chrome/browser/speech/speech_input_extension_manager.cc:214: void
SpeechInputExtensionManager::UnregisterFromManagerOnIOThread() {
On 2012/05/24 09:50:44, Satish wrote:
> UnregisterFromManager is a bit confusing since this class is also named as a
> Manager :) Can we rename this to AbortAllSessionsInIOThread ?
Uh right. Done

http://codereview.chromium.org/10440011/diff/3001/chrome/browser/speech/speec...
chrome/browser/speech/speech_input_extension_manager.cc:220: // envisaged by
browser_main_loop, causing a crash on this line.
On 2012/05/24 09:50:44, Satish wrote:
> 'causing a crash on this line' -> 'so SpeechRecognitionmanager could have been
> freed by now'

Done.