Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: net/base/network_change_notifier.h

Issue 10417002: RefCounted types should not have public destructors, net/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to r139261 Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_log.h ('k') | net/base/stream_listen_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_change_notifier.h
diff --git a/net/base/network_change_notifier.h b/net/base/network_change_notifier.h
index 20ee6eb48aac242773d24714c3fb4e089a81e106..f527acd1423362953dbe9f980545bc33f64165dc 100644
--- a/net/base/network_change_notifier.h
+++ b/net/base/network_change_notifier.h
@@ -52,14 +52,13 @@ class NET_EXPORT NetworkChangeNotifier {
class NET_EXPORT IPAddressObserver {
public:
- virtual ~IPAddressObserver() {}
-
// Will be called when the IP address of the primary interface changes.
// This includes when the primary interface itself changes.
virtual void OnIPAddressChanged() = 0;
protected:
IPAddressObserver() {}
+ virtual ~IPAddressObserver() {}
private:
DISALLOW_COPY_AND_ASSIGN(IPAddressObserver);
@@ -67,16 +66,15 @@ class NET_EXPORT NetworkChangeNotifier {
class NET_EXPORT ConnectionTypeObserver {
public:
- virtual ~ConnectionTypeObserver() {}
-
- // Will be called when the connection type of the system has changed.
- // See NetworkChangeNotifier::GetConnectionType() for important caveats
- // about the unreliability of using this signal to infer the ability to
- // reach remote sites.
+ // Will be called when the connection type of the system has changed.
+ // See NetworkChangeNotifier::GetConnectionType() for important caveats
+ // about the unreliability of using this signal to infer the ability to
+ // reach remote sites.
virtual void OnConnectionTypeChanged(ConnectionType type) = 0;
protected:
ConnectionTypeObserver() {}
+ virtual ~ConnectionTypeObserver() {}
private:
DISALLOW_COPY_AND_ASSIGN(ConnectionTypeObserver);
@@ -84,14 +82,13 @@ class NET_EXPORT NetworkChangeNotifier {
class NET_EXPORT DNSObserver {
public:
- virtual ~DNSObserver() {}
-
// Will be called when the DNS settings of the system may have changed.
// The flags set in |detail| provide the specific set of changes.
virtual void OnDNSChanged(unsigned detail) = 0;
protected:
DNSObserver() {}
+ virtual ~DNSObserver() {}
private:
DISALLOW_COPY_AND_ASSIGN(DNSObserver);
« no previous file with comments | « net/base/net_log.h ('k') | net/base/stream_listen_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698