Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: net/base/net_log.h

Issue 10417002: RefCounted types should not have public destructors, net/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to r139261 Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/base/network_change_notifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log.h
diff --git a/net/base/net_log.h b/net/base/net_log.h
index 1984abf4339fad9581d5d6f51b055ad1bab440b0..777bdf54fe20a697bb34d2c887cff4a6848b4608 100644
--- a/net/base/net_log.h
+++ b/net/base/net_log.h
@@ -121,7 +121,6 @@ class NET_EXPORT NetLog {
// Observers must stop watching a NetLog before either the Observer or the
// NetLog is destroyed.
ThreadSafeObserver();
- virtual ~ThreadSafeObserver();
// Returns the minimum log level for events this observer wants to
// receive. Must not be called when not watching a NetLog.
@@ -153,6 +152,9 @@ class NET_EXPORT NetLog {
EventPhase phase,
EventParameters* params) = 0;
+ protected:
+ virtual ~ThreadSafeObserver();
+
private:
friend class NetLog;
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/base/network_change_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698